You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/27 13:24:05 UTC

[GitHub] [pulsar] liudezhi2098 opened a new pull request, #15353: [python] support listener_name in python client

liudezhi2098 opened a new pull request, #15353:
URL: https://github.com/apache/pulsar/pull/15353

   
   Master Issue: #15325
   
   ### Motivation
   
   
   support listener_name in python client
   
   ### Documentation
   
   Need to update docs? 
   
   - [x] `doc-required` 
   (Your PR needs to update docs and you will update later)
     


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #15353: [python] support listener_name in python client

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on code in PR #15353:
URL: https://github.com/apache/pulsar/pull/15353#discussion_r860523139


##########
pulsar-client-cpp/python/pulsar_test.py:
##########
@@ -1179,6 +1179,16 @@ def test_shutdown_client(self):
             # Expected
             pass
 
+    def test_listener_name_client(self):
+        client = Client(self.serviceUrl, listener_name='test')
+        try:
+            producer = client.create_producer("persistent://public/default/partitioned_topic_name_test")
+            self.assertTrue(False)

Review Comment:
   Use `self.fail()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower merged pull request #15353: [python] support listener_name in python client

Posted by GitBox <gi...@apache.org>.
BewareMyPower merged PR #15353:
URL: https://github.com/apache/pulsar/pull/15353


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on pull request #15353: [python] support listener_name in python client

Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #15353:
URL: https://github.com/apache/pulsar/pull/15353#issuecomment-1111871215

   #### Doc status update
   @liudezhi2098 will submit a follow-up PR to add docs as soon as this PR gets approved and merged.
   Initial scoping: add a new example for listeners to https://pulsar.apache.org/docs/en/next/client-libraries-python/.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #15353: [python] support listener_name in python client

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #15353:
URL: https://github.com/apache/pulsar/pull/15353#issuecomment-1111670855

   @momo-jun a soft reminder: here is a PR w/ doc-required label, could u pls follow up? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org