[GitHub] [druid] zachjsh edited a comment on pull request #11075: Adjust HadoopIndexTask temp segment renaming to avoid potential race conditions

[GitBox <gi...@apache.org>]

zachjsh edited a comment on pull request #11075:
URL: https://github.com/apache/druid/pull/11075#issuecomment-831624436


   > > Hm, we don't have any existing unit tests for HadoopIndexTask, so I think it'd be fine to ignore the coverage failure from that.
   > > Can you run ITHadoopIndexTest locally and check if that passes?
   > 
   > I have a suspicion that this PR may have had an impact on jdk11 execution of Indexing Modules Test. @zachjsh were you able to pass tests locally with jdk11 by chance? If so, I could be wrong here
   > 
   > Edit: It seems to be powermock trying to access java internals from what I can tell
   
   thanks @capistrant! I believe the recent updates I've added fix the issue. I ran both the `indexing-hadoop` and `indexing-service` module unit tests with both java8 and java11 locally, and ran ITHadoopIndexTest locally with both java8 and java11. New pr can be found here https://github.com/apache/druid/pull/11194


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org