You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/18 08:33:46 UTC
[GitHub] [flink] zhengcanbin opened a new pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.1
zhengcanbin opened a new pull request #12215:
URL: https://github.com/apache/flink/pull/12215
## What is the purpose of the change
Bump fabric8 kubernetes-client from 4.5.2 to 4.7.1.
It fixes the issue of [FLINK-17566](https://issues.apache.org/jira/browse/FLINK-17566).
## Brief change log
- Update pom.xml about the `kubernetes.client.version` property.
- Update the NOTICE file.
- Update all the test cases which previously expect the method of `Quantity#getAmount` returns **${memoryAmount}${memoryFormat}**.
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.1
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12215:
URL: https://github.com/apache/flink/pull/12215#issuecomment-630047332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1708",
"triggerID" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f357acabcb13d64d8e9a042af14329415db0f87 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1708)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12215:
URL: https://github.com/apache/flink/pull/12215#issuecomment-630034151
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit fec492efa997636aa6d39d4de6dabf059a89b18b (Fri Oct 16 10:54:44 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12215:
URL: https://github.com/apache/flink/pull/12215#issuecomment-630047332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1708",
"triggerID" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"triggerType" : "PUSH"
}, {
"hash" : "906be78b0943a61b70d4624b95bad5479c9f3d92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1896",
"triggerID" : "906be78b0943a61b70d4624b95bad5479c9f3d92",
"triggerType" : "PUSH"
}, {
"hash" : "65c86e560750386063796783054ed5ea7ea42881",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "65c86e560750386063796783054ed5ea7ea42881",
"triggerType" : "PUSH"
}, {
"hash" : "96ecf9da6d438f616bc9b39b69b0f1c7319b1c34",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1984",
"triggerID" : "96ecf9da6d438f616bc9b39b69b0f1c7319b1c34",
"triggerType" : "PUSH"
}, {
"hash" : "fec492efa997636aa6d39d4de6dabf059a89b18b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1991",
"triggerID" : "fec492efa997636aa6d39d4de6dabf059a89b18b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 65c86e560750386063796783054ed5ea7ea42881 UNKNOWN
* 96ecf9da6d438f616bc9b39b69b0f1c7319b1c34 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1984)
* fec492efa997636aa6d39d4de6dabf059a89b18b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1991)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12215:
URL: https://github.com/apache/flink/pull/12215#issuecomment-630047332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1708",
"triggerID" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"triggerType" : "PUSH"
}, {
"hash" : "906be78b0943a61b70d4624b95bad5479c9f3d92",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1896",
"triggerID" : "906be78b0943a61b70d4624b95bad5479c9f3d92",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f357acabcb13d64d8e9a042af14329415db0f87 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1708)
* 906be78b0943a61b70d4624b95bad5479c9f3d92 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1896)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12215:
URL: https://github.com/apache/flink/pull/12215#issuecomment-630047332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1708",
"triggerID" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"triggerType" : "PUSH"
}, {
"hash" : "906be78b0943a61b70d4624b95bad5479c9f3d92",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1896",
"triggerID" : "906be78b0943a61b70d4624b95bad5479c9f3d92",
"triggerType" : "PUSH"
}, {
"hash" : "65c86e560750386063796783054ed5ea7ea42881",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "65c86e560750386063796783054ed5ea7ea42881",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 906be78b0943a61b70d4624b95bad5479c9f3d92 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1896)
* 65c86e560750386063796783054ed5ea7ea42881 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12215:
URL: https://github.com/apache/flink/pull/12215#issuecomment-630047332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1708",
"triggerID" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"triggerType" : "PUSH"
}, {
"hash" : "906be78b0943a61b70d4624b95bad5479c9f3d92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1896",
"triggerID" : "906be78b0943a61b70d4624b95bad5479c9f3d92",
"triggerType" : "PUSH"
}, {
"hash" : "65c86e560750386063796783054ed5ea7ea42881",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "65c86e560750386063796783054ed5ea7ea42881",
"triggerType" : "PUSH"
}, {
"hash" : "96ecf9da6d438f616bc9b39b69b0f1c7319b1c34",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1984",
"triggerID" : "96ecf9da6d438f616bc9b39b69b0f1c7319b1c34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 65c86e560750386063796783054ed5ea7ea42881 UNKNOWN
* 96ecf9da6d438f616bc9b39b69b0f1c7319b1c34 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1984)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 edited a comment on pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.2
Posted by GitBox <gi...@apache.org>.
wangyang0918 edited a comment on pull request #12215:
URL: https://github.com/apache/flink/pull/12215#issuecomment-631210861
@zhengcanbin Thanks a lot for creating this PR. I am afraid this PR could not work because the new `kubernetes-client` version introduce some additional dependencies(e.g. `com.fasterxml.jackson.datatype:jackson-datatype-jsr310`). Could you please check for that?
```
2020-05-18 14:22:19,882 INFO org.apache.flink.client.deployment.DefaultClusterClientServiceLoader [] - Could not load factory due to missing dependencies.
Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/flink/kubernetes/shaded/com/fasterxml/jackson/datatype/jsr310/JavaTimeModule
at io.fabric8.kubernetes.client.internal.KubeConfigUtils.parseConfigFromString(KubeConfigUtils.java:44)
at io.fabric8.kubernetes.client.Config.loadFromKubeconfig(Config.java:505)
at io.fabric8.kubernetes.client.Config.tryKubeConfig(Config.java:491)
at io.fabric8.kubernetes.client.Config.autoConfigure(Config.java:230)
at io.fabric8.kubernetes.client.Config.<init>(Config.java:214)
at io.fabric8.kubernetes.client.Config.autoConfigure(Config.java:225)
at org.apache.flink.kubernetes.kubeclient.KubeClientFactory.fromConfiguration(KubeClientFactory.java:69)
at org.apache.flink.kubernetes.KubernetesClusterClientFactory.createClusterDescriptor(KubernetesClusterClientFactory.java:58)
at org.apache.flink.kubernetes.KubernetesClusterClientFactory.createClusterDescriptor(KubernetesClusterClientFactory.java:39)
at org.apache.flink.kubernetes.cli.KubernetesSessionCli.run(KubernetesSessionCli.java:95)
at org.apache.flink.kubernetes.cli.KubernetesSessionCli.lambda$main$0(KubernetesSessionCli.java:185)
at org.apache.flink.runtime.security.contexts.NoOpSecurityContext.runSecured(NoOpSecurityContext.java:30)
at org.apache.flink.kubernetes.cli.KubernetesSessionCli.main(KubernetesSessionCli.java:185)
Caused by: java.lang.ClassNotFoundException: org.apache.flink.kubernetes.shaded.com.fasterxml.jackson.datatype.jsr310.JavaTimeModule
at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
... 13 more
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhengcanbin commented on pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.2
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on pull request #12215:
URL: https://github.com/apache/flink/pull/12215#issuecomment-631927890
> @zhengcanbin Thanks a lot for creating this PR. I am afraid this PR could not work because the new `kubernetes-client` version introduce some additional dependencies(e.g. `com.fasterxml.jackson.datatype:jackson-datatype-jsr310`). Could you please check for that?
>
> ```
> 2020-05-18 14:22:19,882 INFO org.apache.flink.client.deployment.DefaultClusterClientServiceLoader [] - Could not load factory due to missing dependencies.
> Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/flink/kubernetes/shaded/com/fasterxml/jackson/datatype/jsr310/JavaTimeModule
> at io.fabric8.kubernetes.client.internal.KubeConfigUtils.parseConfigFromString(KubeConfigUtils.java:44)
> at io.fabric8.kubernetes.client.Config.loadFromKubeconfig(Config.java:505)
> at io.fabric8.kubernetes.client.Config.tryKubeConfig(Config.java:491)
> at io.fabric8.kubernetes.client.Config.autoConfigure(Config.java:230)
> at io.fabric8.kubernetes.client.Config.<init>(Config.java:214)
> at io.fabric8.kubernetes.client.Config.autoConfigure(Config.java:225)
> at org.apache.flink.kubernetes.kubeclient.KubeClientFactory.fromConfiguration(KubeClientFactory.java:69)
> at org.apache.flink.kubernetes.KubernetesClusterClientFactory.createClusterDescriptor(KubernetesClusterClientFactory.java:58)
> at org.apache.flink.kubernetes.KubernetesClusterClientFactory.createClusterDescriptor(KubernetesClusterClientFactory.java:39)
> at org.apache.flink.kubernetes.cli.KubernetesSessionCli.run(KubernetesSessionCli.java:95)
> at org.apache.flink.kubernetes.cli.KubernetesSessionCli.lambda$main$0(KubernetesSessionCli.java:185)
> at org.apache.flink.runtime.security.contexts.NoOpSecurityContext.runSecured(NoOpSecurityContext.java:30)
> at org.apache.flink.kubernetes.cli.KubernetesSessionCli.main(KubernetesSessionCli.java:185)
> Caused by: java.lang.ClassNotFoundException: org.apache.flink.kubernetes.shaded.com.fasterxml.jackson.datatype.jsr310.JavaTimeModule
> at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
> ... 13 more
> ```
True, updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.2
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #12215:
URL: https://github.com/apache/flink/pull/12215#issuecomment-631977115
@zhengcanbin Thanks for the updating. LGTM now.
One more thing, we need to revert this commit 5846e5458e20308db4f0dd1c87d511a60817472c to verify FLINK-17416 is fixed(i.e. Flink on K8s could work on java 8u252). For FLINK-17566, i have verified it could be fixed by this PR.
nit: Maybe we could use fabric8 kubernetes-client version in the commit message, not fabric8 version.
Moreover, could you rebase the latest master to enable the e2e test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12215:
URL: https://github.com/apache/flink/pull/12215#issuecomment-630047332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1708",
"triggerID" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"triggerType" : "PUSH"
}, {
"hash" : "906be78b0943a61b70d4624b95bad5479c9f3d92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1896",
"triggerID" : "906be78b0943a61b70d4624b95bad5479c9f3d92",
"triggerType" : "PUSH"
}, {
"hash" : "65c86e560750386063796783054ed5ea7ea42881",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "65c86e560750386063796783054ed5ea7ea42881",
"triggerType" : "PUSH"
}, {
"hash" : "96ecf9da6d438f616bc9b39b69b0f1c7319b1c34",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1984",
"triggerID" : "96ecf9da6d438f616bc9b39b69b0f1c7319b1c34",
"triggerType" : "PUSH"
}, {
"hash" : "fec492efa997636aa6d39d4de6dabf059a89b18b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fec492efa997636aa6d39d4de6dabf059a89b18b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 65c86e560750386063796783054ed5ea7ea42881 UNKNOWN
* 96ecf9da6d438f616bc9b39b69b0f1c7319b1c34 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1984)
* fec492efa997636aa6d39d4de6dabf059a89b18b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.1
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12215:
URL: https://github.com/apache/flink/pull/12215#issuecomment-630047332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1708",
"triggerID" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f357acabcb13d64d8e9a042af14329415db0f87 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1708)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] TisonKun merged pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.2
Posted by GitBox <gi...@apache.org>.
TisonKun merged pull request #12215:
URL: https://github.com/apache/flink/pull/12215
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12215:
URL: https://github.com/apache/flink/pull/12215#issuecomment-630047332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1708",
"triggerID" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"triggerType" : "PUSH"
}, {
"hash" : "906be78b0943a61b70d4624b95bad5479c9f3d92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1896",
"triggerID" : "906be78b0943a61b70d4624b95bad5479c9f3d92",
"triggerType" : "PUSH"
}, {
"hash" : "65c86e560750386063796783054ed5ea7ea42881",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "65c86e560750386063796783054ed5ea7ea42881",
"triggerType" : "PUSH"
}, {
"hash" : "96ecf9da6d438f616bc9b39b69b0f1c7319b1c34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1984",
"triggerID" : "96ecf9da6d438f616bc9b39b69b0f1c7319b1c34",
"triggerType" : "PUSH"
}, {
"hash" : "fec492efa997636aa6d39d4de6dabf059a89b18b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1991",
"triggerID" : "fec492efa997636aa6d39d4de6dabf059a89b18b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 65c86e560750386063796783054ed5ea7ea42881 UNKNOWN
* fec492efa997636aa6d39d4de6dabf059a89b18b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1991)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12215:
URL: https://github.com/apache/flink/pull/12215#issuecomment-630047332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1708",
"triggerID" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"triggerType" : "PUSH"
}, {
"hash" : "906be78b0943a61b70d4624b95bad5479c9f3d92",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1896",
"triggerID" : "906be78b0943a61b70d4624b95bad5479c9f3d92",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 906be78b0943a61b70d4624b95bad5479c9f3d92 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1896)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12215:
URL: https://github.com/apache/flink/pull/12215#issuecomment-630047332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1708",
"triggerID" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"triggerType" : "PUSH"
}, {
"hash" : "906be78b0943a61b70d4624b95bad5479c9f3d92",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1896",
"triggerID" : "906be78b0943a61b70d4624b95bad5479c9f3d92",
"triggerType" : "PUSH"
}, {
"hash" : "65c86e560750386063796783054ed5ea7ea42881",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "65c86e560750386063796783054ed5ea7ea42881",
"triggerType" : "PUSH"
}, {
"hash" : "96ecf9da6d438f616bc9b39b69b0f1c7319b1c34",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1984",
"triggerID" : "96ecf9da6d438f616bc9b39b69b0f1c7319b1c34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 906be78b0943a61b70d4624b95bad5479c9f3d92 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1896)
* 65c86e560750386063796783054ed5ea7ea42881 UNKNOWN
* 96ecf9da6d438f616bc9b39b69b0f1c7319b1c34 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1984)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.1
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12215:
URL: https://github.com/apache/flink/pull/12215#issuecomment-630047332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f357acabcb13d64d8e9a042af14329415db0f87 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhengcanbin commented on pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.2
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on pull request #12215:
URL: https://github.com/apache/flink/pull/12215#issuecomment-631983535
> @zhengcanbin Thanks for the updating. LGTM now.
>
> One more thing, we need to revert this commit [5846e54](https://github.com/apache/flink/commit/5846e5458e20308db4f0dd1c87d511a60817472c) to verify [FLINK-17416](https://issues.apache.org/jira/browse/FLINK-17416) is fixed(i.e. Flink on K8s could work on java 8u252). For [FLINK-17566](https://issues.apache.org/jira/browse/FLINK-17566), i have verified it could be fixed by this PR.
>
> nit: Maybe we could use fabric8 kubernetes-client version in the commit message, not fabric8 version.
>
> Moreover, could you rebase the latest master to enable the e2e test?
Thanks for the reminder. Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.1
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12215:
URL: https://github.com/apache/flink/pull/12215#issuecomment-630034151
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 5f357acabcb13d64d8e9a042af14329415db0f87 (Mon May 18 08:39:12 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12215:
URL: https://github.com/apache/flink/pull/12215#issuecomment-630047332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1708",
"triggerID" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"triggerType" : "PUSH"
}, {
"hash" : "906be78b0943a61b70d4624b95bad5479c9f3d92",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "906be78b0943a61b70d4624b95bad5479c9f3d92",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f357acabcb13d64d8e9a042af14329415db0f87 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1708)
* 906be78b0943a61b70d4624b95bad5479c9f3d92 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.2
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #12215:
URL: https://github.com/apache/flink/pull/12215#issuecomment-631210861
@zhengcanbin Thanks a lot for creating this PR. I am afraid this PR could not work because the new version introduce some additional dependencies(e.g. `com.fasterxml.jackson.datatype:jackson-datatype-jsr310`). Could you please check for that?
```
2020-05-18 14:22:19,882 INFO org.apache.flink.client.deployment.DefaultClusterClientServiceLoader [] - Could not load factory due to missing dependencies.
Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/flink/kubernetes/shaded/com/fasterxml/jackson/datatype/jsr310/JavaTimeModule
at io.fabric8.kubernetes.client.internal.KubeConfigUtils.parseConfigFromString(KubeConfigUtils.java:44)
at io.fabric8.kubernetes.client.Config.loadFromKubeconfig(Config.java:505)
at io.fabric8.kubernetes.client.Config.tryKubeConfig(Config.java:491)
at io.fabric8.kubernetes.client.Config.autoConfigure(Config.java:230)
at io.fabric8.kubernetes.client.Config.<init>(Config.java:214)
at io.fabric8.kubernetes.client.Config.autoConfigure(Config.java:225)
at org.apache.flink.kubernetes.kubeclient.KubeClientFactory.fromConfiguration(KubeClientFactory.java:69)
at org.apache.flink.kubernetes.KubernetesClusterClientFactory.createClusterDescriptor(KubernetesClusterClientFactory.java:58)
at org.apache.flink.kubernetes.KubernetesClusterClientFactory.createClusterDescriptor(KubernetesClusterClientFactory.java:39)
at org.apache.flink.kubernetes.cli.KubernetesSessionCli.run(KubernetesSessionCli.java:95)
at org.apache.flink.kubernetes.cli.KubernetesSessionCli.lambda$main$0(KubernetesSessionCli.java:185)
at org.apache.flink.runtime.security.contexts.NoOpSecurityContext.runSecured(NoOpSecurityContext.java:30)
at org.apache.flink.kubernetes.cli.KubernetesSessionCli.main(KubernetesSessionCli.java:185)
Caused by: java.lang.ClassNotFoundException: org.apache.flink.kubernetes.shaded.com.fasterxml.jackson.datatype.jsr310.JavaTimeModule
at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
... 13 more
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12215: [FLINK-17565][k8s] Bump fabric8 version from 4.5.2 to 4.9.2
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12215:
URL: https://github.com/apache/flink/pull/12215#issuecomment-630047332
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1708",
"triggerID" : "5f357acabcb13d64d8e9a042af14329415db0f87",
"triggerType" : "PUSH"
}, {
"hash" : "906be78b0943a61b70d4624b95bad5479c9f3d92",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1896",
"triggerID" : "906be78b0943a61b70d4624b95bad5479c9f3d92",
"triggerType" : "PUSH"
}, {
"hash" : "65c86e560750386063796783054ed5ea7ea42881",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "65c86e560750386063796783054ed5ea7ea42881",
"triggerType" : "PUSH"
}, {
"hash" : "96ecf9da6d438f616bc9b39b69b0f1c7319b1c34",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "96ecf9da6d438f616bc9b39b69b0f1c7319b1c34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 906be78b0943a61b70d4624b95bad5479c9f3d92 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1896)
* 65c86e560750386063796783054ed5ea7ea42881 UNKNOWN
* 96ecf9da6d438f616bc9b39b69b0f1c7319b1c34 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org