You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2022/06/23 07:59:01 UTC

[camel] 01/02: (chores) camel-core-model: removed unused parameters

This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 83ccccb86f01ac58c57c345ed39ba40ccd95d85b
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Thu Jun 23 07:35:06 2022 +0200

    (chores) camel-core-model: removed unused parameters
---
 .../main/java/org/apache/camel/model/RouteDefinitionHelper.java    | 7 +++----
 .../src/main/java/org/apache/camel/model/RouteFilters.java         | 4 ++--
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/core/camel-core-model/src/main/java/org/apache/camel/model/RouteDefinitionHelper.java b/core/camel-core-model/src/main/java/org/apache/camel/model/RouteDefinitionHelper.java
index e1d072d2a29..0e27dc6af8a 100644
--- a/core/camel-core-model/src/main/java/org/apache/camel/model/RouteDefinitionHelper.java
+++ b/core/camel-core-model/src/main/java/org/apache/camel/model/RouteDefinitionHelper.java
@@ -362,7 +362,7 @@ public final class RouteDefinitionHelper {
             List<OnCompletionDefinition> onCompletions) {
 
         // init the route inputs
-        initRouteInput(context, route.getInput());
+        initRouteInput();
 
         // abstracts is the cross cutting concerns
         List<ProcessorDefinition<?>> abstracts = new ArrayList<>();
@@ -377,7 +377,7 @@ public final class RouteDefinitionHelper {
         RouteDefinitionHelper.prepareRouteForInit(route, abstracts, lower);
 
         // parent and error handler builder should be initialized first
-        initParentAndErrorHandlerBuilder(context, route, errorHandler, abstracts, onExceptions);
+        initParentAndErrorHandlerBuilder(context, route, errorHandler, onExceptions);
         // validate top-level violations
         validateTopLevel(route.getOutputs());
         // then interceptors
@@ -442,13 +442,12 @@ public final class RouteDefinitionHelper {
         }
     }
 
-    private static void initRouteInput(CamelContext camelContext, FromDefinition input) {
+    private static void initRouteInput() {
         // noop
     }
 
     private static void initParentAndErrorHandlerBuilder(
             CamelContext context, RouteDefinition route, ErrorHandlerDefinition errorHandler,
-            List<ProcessorDefinition<?>> abstracts,
             List<OnExceptionDefinition> onExceptions) {
 
         if (errorHandler != null) {
diff --git a/core/camel-core-model/src/main/java/org/apache/camel/model/RouteFilters.java b/core/camel-core-model/src/main/java/org/apache/camel/model/RouteFilters.java
index eb04bf9a335..f1aa269db50 100644
--- a/core/camel-core-model/src/main/java/org/apache/camel/model/RouteFilters.java
+++ b/core/camel-core-model/src/main/java/org/apache/camel/model/RouteFilters.java
@@ -64,12 +64,12 @@ public final class RouteFilters implements Function<RouteDefinition, Boolean> {
         String id = route.getId();
         String uri = route.getInput() != null ? route.getInput().getEndpointUri() : null;
 
-        boolean answer = filter(route, id, uri);
+        boolean answer = filter(id, uri);
         LOG.debug("Route filter: include={}, exclude={}, id={}, from={} -> {}", includesText, excludesText, id, uri, answer);
         return answer;
     }
 
-    private boolean filter(RouteDefinition route, String id, String uri) {
+    private boolean filter(String id, String uri) {
         boolean match = false;
 
         // exclude takes precedence