You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by GitBox <gi...@apache.org> on 2022/03/14 13:38:16 UTC
[GitHub] [mina-ftpserver] garydgregory opened a new pull request #12: [FTPSERVER-506] Binary compatibility is broken in ftpserver-core 1.1.3,
garydgregory opened a new pull request #12:
URL: https://github.com/apache/mina-ftpserver/pull/12
1.2.0 vs 1.1.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-ftpserver] garydgregory edited a comment on pull request #12: [FTPSERVER-506] Binary compatibility is broken in ftpserver-core 1.1.3,
Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on pull request #12:
URL: https://github.com/apache/mina-ftpserver/pull/12#issuecomment-1066906102
Hello @elecharny ,
The code you quote is completely irrelevant. What matters is that a public interface breaks binary compatibility. Since user can implement the public interface, those implementations no longer complie! The fix is simple and provides both binary and source compatibility. I've seen this in Apache Commons Net and Apache Commons VFS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-ftpserver] elecharny commented on pull request #12: [FTPSERVER-506] Binary compatibility is broken in ftpserver-core 1.1.3,
Posted by GitBox <gi...@apache.org>.
elecharny commented on pull request #12:
URL: https://github.com/apache/mina-ftpserver/pull/12#issuecomment-1066965809
Hi @garydgregor,
sure enough, but I reversed the {{SslConfiguration}} interface to what it was in 1.1.2, so I can't seer how 1.1.4v breaks ther binary compatibility.
Sorry if that sounds dumb, I'm a bit overloaded atm...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-ftpserver] elecharny commented on pull request #12: [FTPSERVER-506] Binary compatibility is broken in ftpserver-core 1.1.3,
Posted by GitBox <gi...@apache.org>.
elecharny commented on pull request #12:
URL: https://github.com/apache/mina-ftpserver/pull/12#issuecomment-1066857244
Hi Gary,
I'm nor sure this is a needed change. The implementation already returns an array containing "TLSv1.2":
```
public class DefaultSslConfiguration implements SslConfiguration {
...
private String[] enabledProtocols = new String[] {"TLSv1.2"};
...
/**
* @see SslConfiguration#getEnabledProtocols()
*/
public String[] getEnabledProtocols() {
return enabledProtocols;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-ftpserver] garydgregory commented on pull request #12: [FTPSERVER-506] Binary compatibility is broken in ftpserver-core 1.1.3,
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #12:
URL: https://github.com/apache/mina-ftpserver/pull/12#issuecomment-1066906102
Hello @elecharny ,
The code you quote is completely irrelevant. What matters is that a public interface breaks binary compatibility. Since user can implement the public interface, those implementations no longer complie! The fix is simple and provides both binary and source compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-ftpserver] garydgregory commented on pull request #12: [FTPSERVER-506] Binary compatibility is broken in ftpserver-core 1.1.3,
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #12:
URL: https://github.com/apache/mina-ftpserver/pull/12#issuecomment-1067086711
> Hi @garydgregor,
>
> sure enough, but I reversed the {{SslConfiguration}} interface to what it was in 1.1.2, so I can't seer how 1.1.4v breaks ther binary compatibility.
>
> Sorry if that sounds dumb, I'm a bit overloaded atm...
Hi @elecharny
1.1.4 is ok 1.2.0 is broken, please see my explanation in Jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org