You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/05/21 04:27:38 UTC
[GitHub] [phoenix] stoty commented on pull request #1236: Update feature branch Phoenix-6387-4.x from 4.x
stoty commented on pull request #1236:
URL: https://github.com/apache/phoenix/pull/1236#issuecomment-845644052
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 3s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 28 new or modified test files. |
||| _ PHOENIX-6387-4.x Compile Tests _ |
| +0 :ok: | mvndep | 5m 19s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 29s | PHOENIX-6387-4.x passed |
| +1 :green_heart: | compile | 1m 33s | PHOENIX-6387-4.x passed |
| +1 :green_heart: | checkstyle | 10m 46s | PHOENIX-6387-4.x passed |
| +1 :green_heart: | javadoc | 2m 25s | PHOENIX-6387-4.x passed |
| +0 :ok: | spotbugs | 4m 15s | root in PHOENIX-6387-4.x has 1009 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 2m 57s | phoenix-core in PHOENIX-6387-4.x has 945 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 51s | phoenix-pherf in PHOENIX-6387-4.x has 51 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 42s | phoenix-tools in PHOENIX-6387-4.x has 3 extant spotbugs warnings. |
| -0 :warning: | patch | 1m 9s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 46s | the patch passed |
| +1 :green_heart: | compile | 1m 33s | the patch passed |
| +1 :green_heart: | cc | 1m 33s | the patch passed |
| -1 :x: | javac | 1m 33s | root generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4) |
| -1 :x: | checkstyle | 10m 49s | root: The patch generated 1681 new + 22489 unchanged - 500 fixed = 24170 total (was 22989) |
| +1 :green_heart: | prototool | 0m 1s | There were no new prototool issues. |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | shelldocs | 0m 2s | There were no new shelldocs issues. |
| -1 :x: | whitespace | 0m 1s | The patch 1 line(s) with tabs. |
| +1 :green_heart: | xml | 0m 14s | The patch has no ill-formed XML file. |
| -1 :x: | javadoc | 0m 49s | phoenix-core generated 1 new + 91 unchanged - 1 fixed = 92 total (was 92) |
| -1 :x: | javadoc | 0m 17s | phoenix-pherf generated 25 new + 33 unchanged - 24 fixed = 58 total (was 57) |
| -1 :x: | javadoc | 1m 15s | root generated 26 new + 124 unchanged - 25 fixed = 150 total (was 149) |
| -1 :x: | spotbugs | 3m 29s | phoenix-core generated 7 new + 943 unchanged - 2 fixed = 950 total (was 945) |
| -1 :x: | spotbugs | 1m 17s | phoenix-pherf generated 12 new + 42 unchanged - 9 fixed = 54 total (was 51) |
| -1 :x: | spotbugs | 1m 2s | phoenix-tools generated 5 new + 0 unchanged - 3 fixed = 5 total (was 3) |
| -1 :x: | spotbugs | 4m 55s | root generated 24 new + 995 unchanged - 14 fixed = 1019 total (was 1009) |
||| _ Other Tests _ |
| -1 :x: | unit | 145m 28s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 47s | The patch does not generate ASF License warnings. |
| | | 224m 11s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.SCHEMA_VERSION_BYTES is a mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 344] |
| | org.apache.phoenix.mapreduce.index.IndexVerificationResultRepository.SHOULD_RETRY_BYTES is a mutable array At IndexVerificationResultRepository.java: At IndexVerificationResultRepository.java:[line 62] |
| | Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61] |
| FindBugs | module:phoenix-pherf |
| | Possible null pointer dereference in org.apache.phoenix.pherf.workload.mt.handlers.RendezvousingWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent) due to return value of called method Dereferenced at RendezvousingWorkHandler.java:org.apache.phoenix.pherf.workload.mt.handlers.RendezvousingWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent) due to return value of called method Dereferenced at RendezvousingWorkHandler.java:[line 76] |
| | Return value of org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.getPhoenixUtil() ignored, but method has no side effect At RendezvousingWorkHandler.java:but method has no side effect At RendezvousingWorkHandler.java:[line 83] |
| | Possible null pointer dereference in org.apache.phoenix.pherf.workload.mt.handlers.TenantOperationWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent) due to return value of called method Dereferenced at TenantOperationWorkHandler.java:org.apache.phoenix.pherf.workload.mt.handlers.TenantOperationWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent) due to return value of called method Dereferenced at TenantOperationWorkHandler.java:[line 65] |
| | Return value of org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.getPhoenixUtil() ignored, but method has no side effect At TenantOperationWorkHandler.java:but method has no side effect At TenantOperationWorkHandler.java:[line 67] |
| | input must be non-null but is marked as nullable At IdleTimeOperationSupplier.java:is marked as nullable At IdleTimeOperationSupplier.java:[lines 51-74] |
| | input must be non-null but is marked as nullable At PreScenarioOperationSupplier.java:is marked as nullable At PreScenarioOperationSupplier.java:[lines 51-85] |
| | A prepared statement is generated from a nonconstant String in org.apache.phoenix.pherf.workload.mt.operations.PreScenarioOperationSupplier$1.apply(TenantOperationInfo) At PreScenarioOperationSupplier.java:from a nonconstant String in org.apache.phoenix.pherf.workload.mt.operations.PreScenarioOperationSupplier$1.apply(TenantOperationInfo) At PreScenarioOperationSupplier.java:[line 74] |
| | input must be non-null but is marked as nullable At QueryOperationSupplier.java:is marked as nullable At QueryOperationSupplier.java:[lines 54-94] |
| | Impossible cast from RuntimeException to java.sql.SQLException in org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.executePreRunOpsForTenant(TenantOperationFactory$TenantView, TenantOperationInfo) At TenantOperationFactory.java:java.sql.SQLException in org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.executePreRunOpsForTenant(TenantOperationFactory$TenantView, TenantOperationInfo) At TenantOperationFactory.java:[line 354] |
| | input must be non-null but is marked as nullable At UpsertOperationSupplier.java:is marked as nullable At UpsertOperationSupplier.java:[lines 58-161] |
| | org.apache.phoenix.pherf.workload.mt.operations.UpsertOperationSupplier$1.apply(TenantOperationInfo) may fail to clean up java.sql.Statement Obligation to clean up resource created at UpsertOperationSupplier.java:up java.sql.Statement Obligation to clean up resource created at UpsertOperationSupplier.java:[line 107] is not discharged |
| | input must be non-null but is marked as nullable At UserDefinedOperationSupplier.java:is marked as nullable At UserDefinedOperationSupplier.java:[lines 43-47] |
| FindBugs | module:phoenix-tools |
| | Found reliance on default encoding in org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String):in org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String): new java.io.FileReader(File) At SchemaSynthesisProcessor.java:[line 193] |
| | org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String) may fail to close stream At SchemaSynthesisProcessor.java:stream At SchemaSynthesisProcessor.java:[line 193] |
| | org.apache.phoenix.schema.SchemaTool.conf should be package protected In SchemaTool.java: In SchemaTool.java |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.SchemaTool.parseOptions(String[]) Dereferenced at SchemaTool.java:cmdLine in org.apache.phoenix.schema.SchemaTool.parseOptions(String[]) Dereferenced at SchemaTool.java:[line 114] |
| | Write to static field org.apache.phoenix.schema.SchemaTool.conf from instance method org.apache.phoenix.schema.SchemaTool.run(String[]) At SchemaTool.java:from instance method org.apache.phoenix.schema.SchemaTool.run(String[]) At SchemaTool.java:[line 73] |
| FindBugs | module:root |
| | org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.SCHEMA_VERSION_BYTES is a mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 344] |
| | org.apache.phoenix.mapreduce.index.IndexVerificationResultRepository.SHOULD_RETRY_BYTES is a mutable array At IndexVerificationResultRepository.java: At IndexVerificationResultRepository.java:[line 62] |
| | Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61] |
| | Possible null pointer dereference in org.apache.phoenix.pherf.workload.mt.handlers.RendezvousingWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent) due to return value of called method Dereferenced at RendezvousingWorkHandler.java:org.apache.phoenix.pherf.workload.mt.handlers.RendezvousingWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent) due to return value of called method Dereferenced at RendezvousingWorkHandler.java:[line 76] |
| | Return value of org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.getPhoenixUtil() ignored, but method has no side effect At RendezvousingWorkHandler.java:but method has no side effect At RendezvousingWorkHandler.java:[line 83] |
| | Possible null pointer dereference in org.apache.phoenix.pherf.workload.mt.handlers.TenantOperationWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent) due to return value of called method Dereferenced at TenantOperationWorkHandler.java:org.apache.phoenix.pherf.workload.mt.handlers.TenantOperationWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent) due to return value of called method Dereferenced at TenantOperationWorkHandler.java:[line 65] |
| | Return value of org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.getPhoenixUtil() ignored, but method has no side effect At TenantOperationWorkHandler.java:but method has no side effect At TenantOperationWorkHandler.java:[line 67] |
| | input must be non-null but is marked as nullable At IdleTimeOperationSupplier.java:is marked as nullable At IdleTimeOperationSupplier.java:[lines 51-74] |
| | input must be non-null but is marked as nullable At PreScenarioOperationSupplier.java:is marked as nullable At PreScenarioOperationSupplier.java:[lines 51-85] |
| | A prepared statement is generated from a nonconstant String in org.apache.phoenix.pherf.workload.mt.operations.PreScenarioOperationSupplier$1.apply(TenantOperationInfo) At PreScenarioOperationSupplier.java:from a nonconstant String in org.apache.phoenix.pherf.workload.mt.operations.PreScenarioOperationSupplier$1.apply(TenantOperationInfo) At PreScenarioOperationSupplier.java:[line 74] |
| | input must be non-null but is marked as nullable At QueryOperationSupplier.java:is marked as nullable At QueryOperationSupplier.java:[lines 54-94] |
| | Impossible cast from RuntimeException to java.sql.SQLException in org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.executePreRunOpsForTenant(TenantOperationFactory$TenantView, TenantOperationInfo) At TenantOperationFactory.java:java.sql.SQLException in org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.executePreRunOpsForTenant(TenantOperationFactory$TenantView, TenantOperationInfo) At TenantOperationFactory.java:[line 354] |
| | input must be non-null but is marked as nullable At UpsertOperationSupplier.java:is marked as nullable At UpsertOperationSupplier.java:[lines 58-161] |
| | org.apache.phoenix.pherf.workload.mt.operations.UpsertOperationSupplier$1.apply(TenantOperationInfo) may fail to clean up java.sql.Statement Obligation to clean up resource created at UpsertOperationSupplier.java:up java.sql.Statement Obligation to clean up resource created at UpsertOperationSupplier.java:[line 107] is not discharged |
| | input must be non-null but is marked as nullable At UserDefinedOperationSupplier.java:is marked as nullable At UserDefinedOperationSupplier.java:[lines 43-47] |
| | Found reliance on default encoding in org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String):in org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String): new java.io.FileReader(File) At SchemaSynthesisProcessor.java:[line 193] |
| | org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String) may fail to close stream At SchemaSynthesisProcessor.java:stream At SchemaSynthesisProcessor.java:[line 193] |
| | org.apache.phoenix.schema.SchemaTool.conf should be package protected In SchemaTool.java: In SchemaTool.java |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.SchemaTool.parseOptions(String[]) Dereferenced at SchemaTool.java:cmdLine in org.apache.phoenix.schema.SchemaTool.parseOptions(String[]) Dereferenced at SchemaTool.java:[line 114] |
| | Write to static field org.apache.phoenix.schema.SchemaTool.conf from instance method org.apache.phoenix.schema.SchemaTool.run(String[]) At SchemaTool.java:from instance method org.apache.phoenix.schema.SchemaTool.run(String[]) At SchemaTool.java:[line 73] |
| Failed junit tests | phoenix.end2end.index.LocalIndexIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1236/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1236 |
| Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit xml compile spotbugs hbaseanti checkstyle cc prototool |
| uname | Linux 266bc5800772 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | PHOENIX-6387-4.x / 67620b1 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| javac | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1236/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1236/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1236/1/artifact/yetus-general-check/output/whitespace-tabs.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1236/1/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1236/1/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-pherf.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1236/1/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1236/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1236/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-pherf.html |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1236/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-tools.html |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1236/1/artifact/yetus-general-check/output/new-spotbugs-root.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1236/1/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1236/1/testReport/ |
| Max. process+thread count | 5739 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-pherf phoenix-tools . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1236/1/console |
| versions | git=2.7.4 maven=3.3.9 shellcheck=0.7.0 spotbugs=4.1.3 prototool=1.10.0-dev |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org