You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2017/05/15 15:11:39 UTC
zeppelin git commit: [ZEPPELIN-2516] Set offset, tolerance for navbar,
actionbar hiding
Repository: zeppelin
Updated Branches:
refs/heads/master d37684403 -> e857070f3
[ZEPPELIN-2516] Set offset, tolerance for navbar, actionbar hiding
### What is this PR for?
Set offset, tolerance for navbar, actionbar hiding. See the attached screenshots.
### What type of PR is it?
[Bug Fix]
### Todos
NONE
### What is the Jira issue?
[ZEPPELIN-2516](https://issues.apache.org/jira/browse/ZEPPELIN-2516)
### How should this be tested?
Refer the screenshots.
### Screenshots (if appropriate)
#### Before
#### After
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
Author: 1ambda <1a...@gmail.com>
Closes #2325 from 1ambda/ZEPPELIN-2516/set-offset-tolerance and squashes the following commits:
5d9317c [1ambda] fix: Set offset, tolerance
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/e857070f
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/e857070f
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/e857070f
Branch: refs/heads/master
Commit: e857070f3bd71f1a9e0413b8c0eaebba1f6f7772
Parents: d376844
Author: 1ambda <1a...@gmail.com>
Authored: Tue May 9 15:46:31 2017 +0900
Committer: Lee moon soo <mo...@apache.org>
Committed: Mon May 15 08:11:36 2017 -0700
----------------------------------------------------------------------
zeppelin-web/src/app/notebook/notebook-actionBar.html | 2 +-
zeppelin-web/src/components/navbar/navbar.html | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/e857070f/zeppelin-web/src/app/notebook/notebook-actionBar.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/notebook-actionBar.html b/zeppelin-web/src/app/notebook/notebook-actionBar.html
index 10368c8..e83e05e 100644
--- a/zeppelin-web/src/app/notebook/notebook-actionBar.html
+++ b/zeppelin-web/src/app/notebook/notebook-actionBar.html
@@ -11,7 +11,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
-<headroom class="noteAction"
+<headroom tolerance="10" offset="30" class="noteAction"
ng-show="note.id && !paragraphUrl">
<h3>
<div style="float: left; width: auto; max-width: 40%"
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/e857070f/zeppelin-web/src/components/navbar/navbar.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/components/navbar/navbar.html b/zeppelin-web/src/components/navbar/navbar.html
index 7d33c02..2cae91b 100644
--- a/zeppelin-web/src/components/navbar/navbar.html
+++ b/zeppelin-web/src/components/navbar/navbar.html
@@ -10,7 +10,7 @@ See the License for the specific language governing permissions and
limitations under the License.
-->
-<headroom class="navbar navbar-inverse navbar-fixed-top"
+<headroom tolerance="10" offset="30" class="navbar navbar-inverse navbar-fixed-top"
style="display: none;" role="navigation"
ng-class="{'displayNavBar': !asIframe}">
<div class="container">