You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/12 08:03:22 UTC

[GitHub] [dolphinscheduler] bdxmq opened a new issue, #11452: [Bug] [Logger Server] Incorrect password regular expression

bdxmq opened a new issue, #11452:
URL: https://github.com/apache/dolphinscheduler/issues/11452

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What happened
   
   SensitiveDataConverter passwordHandler
   /**
        * dataSource sensitive param
        */
       public static final String DATASOURCE_PASSWORD_REGEX = "(?<=((?i)password((\\\\\":\\\\\")|(=')))).*?(?=((\\\\\")|(')))";
   
   The log password printed at runtime is not replaced with * sign
   
   ### What you expected to happen
   
   "password":"view1"
   can replace to
   "password":"****"
   
   ### How to reproduce
   
   the old pattern is ok.
   DATASOURCE_PASSWORD_REGEX = "(?<=(\"password\":\")).*?(?=(\"))"
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   3.0.0
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] bdxmq commented on issue #11452: [Bug] [Logger Server] Incorrect password regular expression

Posted by GitBox <gi...@apache.org>.
bdxmq commented on issue #11452:
URL: https://github.com/apache/dolphinscheduler/issues/11452#issuecomment-1212925417

   version:3.0.0
   shell task
   echo "password":"abcdefg"
   ![image](https://user-images.githubusercontent.com/21127891/184328643-b1d24547-39e1-4610-88f2-2b1eaa234e88.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11452: [Bug] [Logger Server] Incorrect password regular expression

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11452:
URL: https://github.com/apache/dolphinscheduler/issues/11452#issuecomment-1212841350

   Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
   * In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
   * If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] bdxmq commented on issue #11452: [Bug] [Logger Server] Incorrect password regular expression

Posted by GitBox <gi...@apache.org>.
bdxmq commented on issue #11452:
URL: https://github.com/apache/dolphinscheduler/issues/11452#issuecomment-1212955635

   dev is the same as the parttern of 3.0.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] ruanwenjun commented on issue #11452: [Bug] [Logger Server] Incorrect password regular expression

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #11452:
URL: https://github.com/apache/dolphinscheduler/issues/11452#issuecomment-1212941384

   Could you please with the latest regex in dev `(?<=((?i)password((\\\\\":\\\\\")|(=')))).*?(?=((\\\\\")|(')))`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11452: [Bug] [Logger Server] Incorrect password regular expression

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11452:
URL: https://github.com/apache/dolphinscheduler/issues/11452#issuecomment-1243079976

   This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] bdxmq commented on issue #11452: [Bug] [Logger Server] Incorrect password regular expression

Posted by GitBox <gi...@apache.org>.
bdxmq commented on issue #11452:
URL: https://github.com/apache/dolphinscheduler/issues/11452#issuecomment-1212923771

   version:3.0.0
   shell task
   ![image](https://user-images.githubusercontent.com/21127891/184328255-9ae6ae85-7f4e-4be6-91a9-811d98c9547d.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] caishunfeng closed issue #11452: [Bug] [Logger Server] Incorrect password regular expression

Posted by GitBox <gi...@apache.org>.
caishunfeng closed issue #11452: [Bug] [Logger Server] Incorrect password regular expression
URL: https://github.com/apache/dolphinscheduler/issues/11452


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org