[GitHub] matthiasblaesing commented on issue #590: License cleanup part 2

[GitBox <gi...@apache.org>]

matthiasblaesing commented on issue #590: License cleanup part 2
URL: https://github.com/apache/incubator-netbeans/pull/590#issuecomment-397406494
 
 
   I pushed three more commits into this branch (only new commits):
   - the spring jars indeed hold a notice, this is now present
   - testng indeed contains MIT licensed jquery and jcommander holds a NOTICE file (if you dig in the repository, in the distribution it is missing)
   - winp might be discussable. Instead of patching winp, I switched to a maintained version (https://github.com/kohsuke/winp). The libraries code today is very similar to the state after patching (modulo a few years of fixes), so I think this is save. The API is stable (checked with ``japi-compliance-checker`). Part of the winp problem was, that the license integration code is not prepared for files showing up at build time (winp was build from source) and not coming from the normal download route.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists