[GitHub] [unomi] sergehuber commented on a change in pull request #147: UNOMI-300 Fix npm dependencies for web tracker

[GitBox <gi...@apache.org>]

sergehuber commented on a change in pull request #147: UNOMI-300 Fix npm dependencies for web tracker
URL: https://github.com/apache/unomi/pull/147#discussion_r410733763
 
 

 ##########
 File path: extensions/web-tracker/javascript/src/analytics.js-integration-apache-unomi.js
 ##########
 @@ -19,23 +19,26 @@
 var integration = require('@segment/analytics.js-integration');
 var extend  = require('extend');
 
-var Unomi = module.exports = integration('Apache Unomi')
+var Unomi = (module.exports = integration('Apache Unomi')
+    .global('cxs')
     .assumesPageview()
     .readyOnLoad()
-    .global('cxs')
     .option('scope', 'systemscope')
     .option('url', 'http://localhost:8181')
     .option('timeoutInMilliseconds', 1500)
     .option('sessionCookieName', 'unomiSessionId')
-    .option('sessionId');
+    .option('sessionId'));
 
 /**
  * Initialize.
  *
  * @api public
  */
-Unomi.prototype.initialize = function(page) {
+Unomi.prototype.initialize = function() {
     var self = this;
+
+    console.info('[UNOMI] Initializing...', arguments);
 
 Review comment:
   This is a standard built-in variables exposed by functions, see : https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/arguments

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services