[GitHub] [hive] kasakrisz commented on a change in pull request #2984: HIVE-25900: Materialized view registry does not clean non existing views at refresh

[GitBox <gi...@apache.org>]

kasakrisz commented on a change in pull request #2984:
URL: https://github.com/apache/hive/pull/2984#discussion_r795382940



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
##########
@@ -97,23 +98,83 @@
   private static final Logger LOG = LoggerFactory.getLogger(HiveMaterializedViewsRegistry.class);
   private static final String CLASS_NAME = HiveMaterializedViewsRegistry.class.getName();
 
-  /* Singleton */
-  private static final HiveMaterializedViewsRegistry SINGLETON = new HiveMaterializedViewsRegistry();
+  /**
+   * Registry for materialized views. The goal of this cache is to avoid parsing and creating
+   * logical plans for the materialized views at query runtime. When a query arrives, we will
+   * just need to consult this cache and extract the logical plans for the views (which had
+   * already been parsed) from it. This cache lives in HS2.
+   */

Review comment:
       removed one of them




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org