[GitHub] [iceberg] rdblue commented on a diff in pull request #4873: Core - Let TableMetadata be parsed from JSON without FileIO by deprecating FileIO in BaseSnapshot

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #4873:
URL: https://github.com/apache/iceberg/pull/4873#discussion_r882196477


##########
api/src/main/java/org/apache/iceberg/Snapshot.java:
##########
@@ -68,23 +69,58 @@ public interface Snapshot extends Serializable {
    * Return all {@link ManifestFile} instances for either data or delete manifests in this snapshot.
    *
    * @return a list of ManifestFile
+   * @deprecated since 1.0.0 - Use {@link Snapshot#allManifests(FileIO)} instead.

Review Comment:
   Instead of saying when it was deprecated, I think we should say when it will be removed. I'm thinking that will probably be 1.0.0, assuming that we do an 0.14.0 and then follow up with a 1.0.0 to remove deprecations, but open to other opinions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org