You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2015/09/14 04:56:38 UTC
incubator-kylin git commit: minor, fix test case BadQueryDetectorTest
Repository: incubator-kylin
Updated Branches:
refs/heads/2.x-staging 6d22f3fe7 -> 8ac3f08b5
minor, fix test case BadQueryDetectorTest
Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/8ac3f08b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/8ac3f08b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/8ac3f08b
Branch: refs/heads/2.x-staging
Commit: 8ac3f08b596763f7ba69e0e0f5a6ea3614f415cd
Parents: 6d22f3f
Author: Li, Yang <ya...@ebay.com>
Authored: Mon Sep 14 10:56:23 2015 +0800
Committer: Li, Yang <ya...@ebay.com>
Committed: Mon Sep 14 10:56:23 2015 +0800
----------------------------------------------------------------------
.../kylin/rest/service/BadQueryDetectorTest.java | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/8ac3f08b/server/src/test/java/org/apache/kylin/rest/service/BadQueryDetectorTest.java
----------------------------------------------------------------------
diff --git a/server/src/test/java/org/apache/kylin/rest/service/BadQueryDetectorTest.java b/server/src/test/java/org/apache/kylin/rest/service/BadQueryDetectorTest.java
index b38ee9d..c849efd 100644
--- a/server/src/test/java/org/apache/kylin/rest/service/BadQueryDetectorTest.java
+++ b/server/src/test/java/org/apache/kylin/rest/service/BadQueryDetectorTest.java
@@ -35,7 +35,7 @@ public class BadQueryDetectorTest {
String mockSql = "select * from just_a_test";
final ArrayList<String[]> alerts = new ArrayList<>();
- BadQueryDetector badQueryDetector = new BadQueryDetector(5000, alertMB, alertRunningSec);
+ BadQueryDetector badQueryDetector = new BadQueryDetector(alertRunningSec * 1000, alertMB, alertRunningSec);
badQueryDetector.registerNotifier(new BadQueryDetector.Notifier() {
@Override
public void badQueryFound(String adj, int runningSec, String sql) {
@@ -45,19 +45,25 @@ public class BadQueryDetectorTest {
badQueryDetector.start();
{
+ Thread.sleep(1000);
+
SQLRequest sqlRequest = new SQLRequest();
sqlRequest.setSql(mockSql);
badQueryDetector.queryStart(Thread.currentThread(), sqlRequest);
- Thread.sleep(alertRunningSec * 2 * 1000);
+ // make sure bad query check happens twice
+ Thread.sleep((alertRunningSec * 2 + 1) * 1000);
badQueryDetector.queryEnd(Thread.currentThread());
}
badQueryDetector.stop();
- assertEquals(2, alerts.size());
+ assertEquals(3, alerts.size());
+ // first check founds Low mem
assertArrayEquals(new String[] { "Low mem", mockSql }, alerts.get(0));
- assertArrayEquals(new String[] { "Slow", mockSql }, alerts.get(1));
+ // second check founds Low mem & Slow
+ assertArrayEquals(new String[] { "Low mem", mockSql }, alerts.get(1));
+ assertArrayEquals(new String[] { "Slow", mockSql }, alerts.get(2));
}
}