[GitHub] [spark] itholic commented on a diff in pull request #36711: [SPARK-39314][PS] Respect ps.concat sort parameter to follow pandas behavior

[GitBox <gi...@apache.org>]

itholic commented on code in PR #36711:
URL: https://github.com/apache/spark/pull/36711#discussion_r884369798


##########
python/pyspark/pandas/tests/test_namespace.py:
##########
@@ -306,16 +329,30 @@ def test_concat_index_axis(self):
 
         objs = [
             ([psdf, psdf], [pdf, pdf]),
+            # no Series
             ([psdf, psdf.reset_index()], [pdf, pdf.reset_index()]),
             ([psdf.reset_index(), psdf], [pdf.reset_index(), pdf]),
             ([psdf, psdf[["C", "A"]]], [pdf, pdf[["C", "A"]]]),
             ([psdf[["C", "A"]], psdf], [pdf[["C", "A"]], pdf]),
+            # only one Series
             ([psdf, psdf["C"]], [pdf, pdf["C"]]),
+            # only one Series

Review Comment:
   nit: maybe we can remove this comment here ? The above one should cover.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org