[GitHub] [ozone] smengcl commented on pull request #3125: HDDS-6365. Relax protolock rule to allow changing field names

[GitBox <gi...@apache.org>]

smengcl commented on PR #3125:
URL: https://github.com/apache/ozone/pull/3125#issuecomment-1380825038

   > @smengcl I think it might be ok to do this for a single change and then revert it. Making this change permanent has the potential to hurt us more than help us. Renaming existing fields without breaking wire compatibility is essential to keep code readability. I am ok with making the change, renaming, and then changing it back.
   
   Yup I agree. Though if we need to make a one-off rename we probably just need to update the proto lock file in that same PR as well.
   
   Closed this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org