You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "rickyma (via GitHub)" <gi...@apache.org> on 2024/03/06 08:13:18 UTC

[PR] [#1561] feat(spark): Support Spark 2.1 [incubator-uniffle]

rickyma opened a new pull request, #1562:
URL: https://github.com/apache/incubator-uniffle/pull/1562

   ### What changes were proposed in this pull request?
   
   Support Spark 2.1
   
   ### Why are the changes needed?
   
   For https://github.com/apache/incubator-uniffle/issues/1561
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Existing UTs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1561] feat(spark): Support Spark 2.1 [incubator-uniffle]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1562:
URL: https://github.com/apache/incubator-uniffle/pull/1562#issuecomment-1980340418

   ## Test Results
    2 453 files  +141   2 453 suites  +141   4h 46m 2s :stopwatch: + 10m 26s
      823 tests ±  0     822 :white_check_mark: ±  0   1 :zzz: ±0  0 :x: ±0 
   10 346 runs  +649  10 331 :white_check_mark: +648  15 :zzz: +1  0 :x: ±0 
   
   Results for commit 1ed1ea5a. ± Comparison against base commit d8aedf34.
   
   [test-results]:data:application/gzip;base64,H4sIAAcr6GUC/03Myw7CIBCF4VdpWLvozBSKvoxBLgmxF0Nh1fju0qYgy/Mx/DtzfrIbe3Q4cLp1bEs+ttukoKJflywwgsBM+T0eFxKprOeWtD4J//T2n+NXBaf8lKGvYENYwyUhLUcTehrENUs0G0G1q8oLNNVzt1G9zrOPeTCwBqziynI9SgfkbI/8JUhI0uYuBiNBO0TOvj9pf+nvEgEAAA==
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1561] feat(spark): Support Spark 2.1 [incubator-uniffle]

Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma closed pull request #1562: [#1561] feat(spark): Support Spark 2.1
URL: https://github.com/apache/incubator-uniffle/pull/1562


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1561] feat(spark): Support Spark 2.1 [incubator-uniffle]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1562:
URL: https://github.com/apache/incubator-uniffle/pull/1562#issuecomment-1980315482

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1562?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 54.80%. Comparing base [(`d8aedf3`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/d8aedf342337a39afe51f5f21d81f2671ca2a2ed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`1ed1ea5`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1562?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1562      +/-   ##
   ============================================
   + Coverage     53.65%   54.80%   +1.14%     
   + Complexity     2818     2277     -541     
   ============================================
     Files           436      363      -73     
     Lines         24549    15764    -8785     
     Branches       2080     1427     -653     
   ============================================
   - Hits          13172     8639    -4533     
   + Misses        10554     6623    -3931     
   + Partials        823      502     -321     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1562?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1561] feat(spark): Support Spark 2.1 [incubator-uniffle]

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1562:
URL: https://github.com/apache/incubator-uniffle/pull/1562#issuecomment-1980680281

   Spark 2.1 has been used in little companies. They are easy to upgrade to Spark 2.4.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org