You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "ZhangHuiGui (via GitHub)" <gi...@apache.org> on 2024/04/07 01:59:07 UTC

[I] [C++] ListArray's Flatten function should support recursive flattening of nested lists [arrow]

ZhangHuiGui opened a new issue, #41055:
URL: https://github.com/apache/arrow/issues/41055

   ### Describe the enhancement requested
   
   The function `FlattenListArray` seems only support flat the list array like `list(int32)`, 
   https://github.com/apache/arrow/blob/6aa33210ecd9773f18ceb775306b79de132b6c6f/cpp/src/arrow/array/array_nested.cc#L240-L254
   
   Users need to flatten nested list-arrays, and then the upper layer needs to implement recursive flatten, which seems inconvenient for them. 
   
   @felipecrv  do you think we should implement this internally?
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] ListArray's Flatten function should support recursive flattening of nested lists [arrow]

Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv closed issue #41055: [C++] ListArray's Flatten function should support recursive flattening of nested lists
URL: https://github.com/apache/arrow/issues/41055


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] ListArray's Flatten function should support recursive flattening of nested lists [arrow]

Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on issue #41055:
URL: https://github.com/apache/arrow/issues/41055#issuecomment-2043592891

   > Users need to flatten nested list-arrays( list(list(int32)) ), and then the upper layer needs to implement recursive flatten, which seems inconvenient for them.
   
   Right. But we can't change the behavior of existing `Flatten` to go recursive, but we can add a version that works recursively (and is not naively doing successive concatenations). And yes, it would treat all of `(Large)?List(View)?` as logical lists that need to be flattened until a non-list-like type is reached.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] ListArray's Flatten function should support recursive flattening of nested lists [arrow]

Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on issue #41055:
URL: https://github.com/apache/arrow/issues/41055#issuecomment-2045797592

   And we shouldn't forget `fixed_size_list` either. It's logically a list as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [C++] ListArray's Flatten function should support recursive flattening of nested lists [arrow]

Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on issue #41055:
URL: https://github.com/apache/arrow/issues/41055#issuecomment-2057504598

   Issue resolved by pull request 41092
   https://github.com/apache/arrow/pull/41092


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org