[GitHub] [tinkerpop] vtslab edited a comment on pull request #1308: TINKERPOP-2389 WIP: Authorization support in TinkerPop

[GitBox <gi...@apache.org>]

vtslab edited a comment on pull request #1308:
URL: https://github.com/apache/tinkerpop/pull/1308#issuecomment-687849953


   Thanks for the explanation @QwentB, this makes sense. Apart from making unit tests, your request is really simple: allow the Authenticator implementation to pass on some user defined properties (typically a Map) inside the returned AuthenticatedUser. The current Authorizer proposal already receives the AuthenticatedUser and can read the user defined properties if it has knowledge about their meaning. TinkerPop itself has no knowledge about the user defined properties: it just allows for solutions that implement both the Authenticator and Authorizer interfaces and leverage the channelizer to store and pass on the user defined properties. 
   [Edit 7 sep] Note that the Authenticator/Authorizer implementation could cache the user-defined properties itself, but it would not know when the websockets connection closed and the properties could be released from the cache.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org