You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/14 09:32:11 UTC
[GitHub] [incubator-shardingsphere] kimmking opened a new issue #4309:
Refactor properties mechanism to ensure orchestration own props make effect
kimmking opened a new issue #4309: Refactor properties mechanism to ensure orchestration own props make effect
URL: https://github.com/apache/incubator-shardingsphere/issues/4309
Hello,
Dongzl find a bug that orchestration module can't read its own props config in yaml file [ #4270 ], cause Properties can't get a non-string key.
And then our analysis indicate the global props are enhanced to process Boolean/Integer type using ShardingSphereProperties & PropertiesConstant.
So now we should refactor this properties mechanism to allow more module use the enhancement of properties.
Dongzl and I will follow this issue.
Let's discuss about this issue here. Any question or suggestion is welcome.
And now we should fullfill the following tasks：
- [ ] Refactor properties mechanism to support more than one Enum class, adding TypedInterface and TypedProperties
- [ ] Create an OrchestrationEnum and OrchestrationProperties to ensure orchestration own props make effect
- [ ] Reorganize and improve the unit tests of this feature
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #4309:
Refactor properties mechanism to ensure orchestration own props make effect
Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #4309: Refactor properties mechanism to ensure orchestration own props make effect
URL: https://github.com/apache/incubator-shardingsphere/issues/4309#issuecomment-591878437
As UnitTest tasks moved to #4439
So this issue should be closed now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking closed issue #4309: Refactor
properties mechanism to ensure orchestration own props make effect
Posted by GitBox <gi...@apache.org>.
kimmking closed issue #4309: Refactor properties mechanism to ensure orchestration own props make effect
URL: https://github.com/apache/incubator-shardingsphere/issues/4309
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking opened a new issue #4309:
Refactor properties mechanism to ensure orchestration own props make effect
Posted by GitBox <gi...@apache.org>.
kimmking opened a new issue #4309: Refactor properties mechanism to ensure orchestration own props make effect
URL: https://github.com/apache/incubator-shardingsphere/issues/4309
Hello,
Dongzl find a bug that orchestration module can't read its own props config in yaml file [ #4270 ], cause Properties can't get a non-string key.
And then our analysis indicate the global props are enhanced to process Boolean/Integer type using ShardingSphereProperties & PropertiesConstant.
So now we should refactor this properties mechanism to allow more module use the enhancement of properties.
Dongzl and I will follow this issue.
Let's discuss about this issue here. Any question or suggestion is welcome.
And now we should fullfill the following tasks：
- [x] Refactor properties mechanism to support more than one Enum class, adding TypedInterface and TypedProperties
- [ ] Create an OrchestrationEnum and OrchestrationProperties to ensure orchestration own props make effect
- [ ] Reorganize and improve the unit tests of this feature
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4309: Refactor
properties mechanism to ensure orchestration own props make effect
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #4309: Refactor properties mechanism to ensure orchestration own props make effect
URL: https://github.com/apache/incubator-shardingsphere/issues/4309
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services