[GitHub] [arrow] kou commented on pull request #34866: GH-34862: [Java] Adding ArrowAcero for Dataset module dependency

["kou (via GitHub)" <gi...@apache.org>]

kou commented on PR #34866:
URL: https://github.com/apache/arrow/pull/34866#issuecomment-1497024728

   Sure!
   
   I think that we should fix this in C++ side no Java side.
   
   Could you revert the current change and apply the following patch?
   
   ```diff
   diff --git a/cpp/src/arrow/dataset/CMakeLists.txt b/cpp/src/arrow/dataset/CMakeLists.txt
   index e1b14b77c4..bdc65573b4 100644
   --- a/cpp/src/arrow/dataset/CMakeLists.txt
   +++ b/cpp/src/arrow/dataset/CMakeLists.txt
   @@ -25,6 +25,7 @@ set(ARROW_DATASET_SRCS
        discovery.cc
        file_base.cc
        file_ipc.cc
   +    file_parquet.cc
        partition.cc
        plan.cc
        projector.cc
   @@ -39,39 +40,26 @@ endif()
    
    set(ARROW_DATASET_STATIC_LINK_LIBS)
    set(ARROW_DATASET_SHARED_LINK_LIBS)
   -set(ARROW_DATASET_STATIC_INSTALL_INTERFACE_LIBS)
   -set(ARROW_DATASET_SHARED_INSTALL_INTERFACE_LIBS)
   +set(ARROW_DATASET_STATIC_INSTALL_INTERFACE_LIBS ArrowAcero::arrow_acero_static)
   +set(ARROW_DATASET_SHARED_INSTALL_INTERFACE_LIBS ArrowAcero::arrow_acero_shared)
    
    if(ARROW_CSV)
   -  set(ARROW_DATASET_SRCS ${ARROW_DATASET_SRCS} file_csv.cc)
   +  list(APPEND ARROW_DATASET_SRCS file_csv.cc)
    endif()
    
    if(ARROW_JSON)
   -  set(ARROW_DATASET_SRCS ${ARROW_DATASET_SRCS} file_json.cc)
   +  list(APPEND ARROW_DATASET_SRCS file_json.cc)
    endif()
    
    if(ARROW_ORC)
   -  set(ARROW_DATASET_SRCS ${ARROW_DATASET_SRCS} file_orc.cc)
   -endif()
   -
   -if(ARROW_PARQUET)
   -  list(APPEND ARROW_DATASET_STATIC_LINK_LIBS parquet_static)
   -  list(APPEND ARROW_DATASET_SHARED_LINK_LIBS parquet_shared)
   -  list(APPEND ARROW_DATASET_STATIC_INSTALL_INTERFACE_LIBS Parquet::parquet_static)
   -  list(APPEND ARROW_DATASET_SHARED_INSTALL_INTERFACE_LIBS Parquet::parquet_shared)
   -  list(APPEND ARROW_DATASET_SRCS file_parquet.cc)
   -  list(APPEND ARROW_DATASET_PRIVATE_INCLUDES ${PROJECT_SOURCE_DIR}/src/parquet)
   -else()
   -  list(APPEND ARROW_DATASET_STATIC_INSTALL_INTERFACE_LIBS Arrow::arrow_static)
   -  list(APPEND ARROW_DATASET_SHARED_INSTALL_INTERFACE_LIBS Arrow::arrow_shared)
   +  list(APPEND ARROW_DATASET_SRCS file_orc.cc)
    endif()
    
    list(APPEND
         ARROW_DATASET_STATIC_LINK_LIBS
   -     arrow_static
         arrow_acero_static
         ${ARROW_STATIC_LINK_LIBS})
   -list(APPEND ARROW_DATASET_SHARED_LINK_LIBS arrow_shared arrow_acero_shared)
   +list(APPEND ARROW_DATASET_SHARED_LINK_LIBS arrow_acero_shared)
    
    add_arrow_lib(arrow_dataset
                  CMAKE_PACKAGE_NAME
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org