You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Carlos Sanchez <ca...@apache.org> on 2006/06/23 13:05:05 UTC
Enforcing quality metrics [Was svn commit: r416184 - /maven/pom/maven/pom.xml]
i think it's something that while you are working on it is easy to
fix, but if you receive the notification after some time it's more
annoying, opening again the file, fix it, submit again, see if it
fails...
I think it's like test coverage, if you don't have enough you can't
leave the sandbox, and once you leave it you are required to keep the
quality of the work.
I agree that there may be exceptions when it needs to be skipped for a
good reason, but I see that as exceptions more than the rule.
It's like the repository, as there are no policies enforced
automatically, you can deploy and then chase the people, which slows
down the work of other people.
And right now i just added duplication report, thinking that it's a no
no to include duplicated lines. In the future I'd like to add
checkstyle and PMD.
my 2 cents
---------- Forwarded message ----------
From: Brett Porter <br...@apache.org>
Date: Jun 23, 2006 3:48 AM
Subject: Re: svn commit: r416184 - /maven/pom/maven/pom.xml
To: Maven Developers List <de...@maven.apache.org>
If it slows down the build, people will turn it off forcably/complain,
etc too.
We can enable the profile for CI and deployment, which might make it
better. WDYT?
However, I don't know if this should be a "deployment failure" type
issue - I'd be happy with daily nags on it.
- Brett
On 23/06/2006 11:42 AM, Carlos Sanchez wrote:
> My (limited) experience tells me that if you don't enforce it you
> don't get it done
>
> If it's in a profile I can deploy it and then continuum will fail and
> somebody will have to chase me and tell me and then I'd have to fix
> it, which means that the turnaround is pretty big.
>
> I just added now the duplicate lines thing but I'd like to add also
> checkstyle and pmd to enforce some common rules.
>
> On 6/23/06, Brett Porter <br...@apache.org> wrote:
>> So, you'll fix all duplications when you change the parent?
>>
>> I still believe this should be in a profile used by CI. The standard
>> build doesn't need to worry about this.
>>
>> - Brett
>>
>> On 23/06/2006 1:18 AM, Carlos Sanchez wrote:
>> > That's the point, don't accept files with duplications. Better enforce
>> > it proactively.
>> >
>> > On 6/22/06, Brett Porter <br...@apache.org> wrote:
>> >> On 22/06/2006 10:27 AM, carlos@apache.org wrote:
>> >> > Author: carlos
>> >> > Date: Wed Jun 21 17:27:49 2006
>> >> > New Revision: 416184
>> >> >
>> >> > URL: http://svn.apache.org/viewvc?rev=416184&view=rev
>> >> > Log:
>> >> > Added checkstyle configuration and pmd check for duplications
>> >>
>> >> Won't that fail the build?
>> >>
>> >> Shouldn't the checks be in a profile?
>> >>
>> >> - Brett
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> For additional commands, e-mail: dev-help@maven.apache.org
>> >>
>> >>
>> >
>> >
>>
>>
>> --
>> Brett Porter <br...@apache.org>
>> Apache Maven - http://maven.apache.org/
>> Better Builds with Maven - http://library.mergere.com/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
--
Brett Porter <br...@apache.org>
Apache Maven - http://maven.apache.org/
Better Builds with Maven - http://library.mergere.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
-- The Princess Bride
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Enforcing quality metrics [Was svn commit: r416184 - /maven/pom/maven/pom.xml]
Posted by Brett Porter <br...@apache.org>.
Ah, ok. I had a brain explosion.
I kept seeing cpd-check, not cpd ;)
FYI, there are already some reports, and some stricter controls in the
repository-manager. It would be good to push some (the reports?) up to
have them from the maven pom and the individual projects can just
override the necessary settings.
- Brett
On 24/06/2006 10:17 PM, Carlos Sanchez wrote:
> This change is only to run the duplicate code check, so it won't break
> stuff (hopefully).
> This is the first small step in that gradual direction you're talking
> about.
>
> On 6/24/06, Brett Porter <br...@apache.org> wrote:
>> People don't necessarily even build outside of the IDE before committing
>> so it may not matter :)
>>
>> We should ideally have an immediate integration build notification (or
>> block commit on it!), but I do see your point.
>>
>> The minimum I'd settle for here is a profile that is enabled by default
>> and can be disabled, but I'm still not sure I like that. I like builds
>> to be fast generally, and I like being disciplined about running the
>> appropriate extra tests before committing and am prepared to get
>> publicly slapped by CI when I don't.
>>
>> Aside from this, the thing I don't like about the current changes is
>> that the first innocent victim that updates to the new parent POM for
>> whatever reason will toast the entire Maven build. We need to take baby
>> steps. Getting it in with just warnings or lower settings is a good
>> first step.
>>
>> I applaud your efforts on this, I really do. I'd like to see it go
>> further with cobertura coverage and clirr api checks.
>>
>> I think we just need to be a bit more gradual in its introduction IMO...
>>
>> - Brett
>>
>> On 23/06/2006 9:05 PM, Carlos Sanchez wrote:
>> > i think it's something that while you are working on it is easy to
>> > fix, but if you receive the notification after some time it's more
>> > annoying, opening again the file, fix it, submit again, see if it
>> > fails...
>> >
>> > I think it's like test coverage, if you don't have enough you can't
>> > leave the sandbox, and once you leave it you are required to keep the
>> > quality of the work.
>> >
>> > I agree that there may be exceptions when it needs to be skipped for a
>> > good reason, but I see that as exceptions more than the rule.
>> >
>> > It's like the repository, as there are no policies enforced
>> > automatically, you can deploy and then chase the people, which slows
>> > down the work of other people.
>> >
>> > And right now i just added duplication report, thinking that it's a no
>> > no to include duplicated lines. In the future I'd like to add
>> > checkstyle and PMD.
>> >
>> > my 2 cents
>> >
>>
>> --
>> Brett Porter <br...@apache.org>
>> Apache Maven - http://maven.apache.org/
>> Better Builds with Maven - http://library.mergere.com/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
--
Brett Porter <br...@apache.org>
Apache Maven - http://maven.apache.org/
Better Builds with Maven - http://library.mergere.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Enforcing quality metrics [Was svn commit: r416184 - /maven/pom/maven/pom.xml]
Posted by Carlos Sanchez <ca...@apache.org>.
This change is only to run the duplicate code check, so it won't break
stuff (hopefully).
This is the first small step in that gradual direction you're talking about.
On 6/24/06, Brett Porter <br...@apache.org> wrote:
> People don't necessarily even build outside of the IDE before committing
> so it may not matter :)
>
> We should ideally have an immediate integration build notification (or
> block commit on it!), but I do see your point.
>
> The minimum I'd settle for here is a profile that is enabled by default
> and can be disabled, but I'm still not sure I like that. I like builds
> to be fast generally, and I like being disciplined about running the
> appropriate extra tests before committing and am prepared to get
> publicly slapped by CI when I don't.
>
> Aside from this, the thing I don't like about the current changes is
> that the first innocent victim that updates to the new parent POM for
> whatever reason will toast the entire Maven build. We need to take baby
> steps. Getting it in with just warnings or lower settings is a good
> first step.
>
> I applaud your efforts on this, I really do. I'd like to see it go
> further with cobertura coverage and clirr api checks.
>
> I think we just need to be a bit more gradual in its introduction IMO...
>
> - Brett
>
> On 23/06/2006 9:05 PM, Carlos Sanchez wrote:
> > i think it's something that while you are working on it is easy to
> > fix, but if you receive the notification after some time it's more
> > annoying, opening again the file, fix it, submit again, see if it
> > fails...
> >
> > I think it's like test coverage, if you don't have enough you can't
> > leave the sandbox, and once you leave it you are required to keep the
> > quality of the work.
> >
> > I agree that there may be exceptions when it needs to be skipped for a
> > good reason, but I see that as exceptions more than the rule.
> >
> > It's like the repository, as there are no policies enforced
> > automatically, you can deploy and then chase the people, which slows
> > down the work of other people.
> >
> > And right now i just added duplication report, thinking that it's a no
> > no to include duplicated lines. In the future I'd like to add
> > checkstyle and PMD.
> >
> > my 2 cents
> >
>
> --
> Brett Porter <br...@apache.org>
> Apache Maven - http://maven.apache.org/
> Better Builds with Maven - http://library.mergere.com/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
-- The Princess Bride
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Enforcing quality metrics [Was svn commit: r416184 - /maven/pom/maven/pom.xml]
Posted by Brett Porter <br...@apache.org>.
People don't necessarily even build outside of the IDE before committing
so it may not matter :)
We should ideally have an immediate integration build notification (or
block commit on it!), but I do see your point.
The minimum I'd settle for here is a profile that is enabled by default
and can be disabled, but I'm still not sure I like that. I like builds
to be fast generally, and I like being disciplined about running the
appropriate extra tests before committing and am prepared to get
publicly slapped by CI when I don't.
Aside from this, the thing I don't like about the current changes is
that the first innocent victim that updates to the new parent POM for
whatever reason will toast the entire Maven build. We need to take baby
steps. Getting it in with just warnings or lower settings is a good
first step.
I applaud your efforts on this, I really do. I'd like to see it go
further with cobertura coverage and clirr api checks.
I think we just need to be a bit more gradual in its introduction IMO...
- Brett
On 23/06/2006 9:05 PM, Carlos Sanchez wrote:
> i think it's something that while you are working on it is easy to
> fix, but if you receive the notification after some time it's more
> annoying, opening again the file, fix it, submit again, see if it
> fails...
>
> I think it's like test coverage, if you don't have enough you can't
> leave the sandbox, and once you leave it you are required to keep the
> quality of the work.
>
> I agree that there may be exceptions when it needs to be skipped for a
> good reason, but I see that as exceptions more than the rule.
>
> It's like the repository, as there are no policies enforced
> automatically, you can deploy and then chase the people, which slows
> down the work of other people.
>
> And right now i just added duplication report, thinking that it's a no
> no to include duplicated lines. In the future I'd like to add
> checkstyle and PMD.
>
> my 2 cents
>
--
Brett Porter <br...@apache.org>
Apache Maven - http://maven.apache.org/
Better Builds with Maven - http://library.mergere.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org