You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/02/07 10:30:45 UTC
[GitHub] [incubator-doris] yangzhg opened a new pull request #2858: fix core
when using grouping sets in large data
yangzhg opened a new pull request #2858: fix core when using grouping sets in large data
URL: https://github.com/apache/incubator-doris/pull/2858
fix a core when using grouping sets in large data
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request
#2858: fix core when using grouping sets in large data
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #2858: fix core when using grouping sets in large data
URL: https://github.com/apache/incubator-doris/pull/2858#discussion_r376394391
##########
File path: be/src/exec/repeat_node.cpp
##########
@@ -100,10 +93,18 @@ Status RepeatNode::get_repeated_batch(
continue;
}
- char* new_tuple = reinterpret_cast<char*>(dst_tuples[j]);
- new_tuple += (*dst_it)->byte_size();
- dst_tuples[j] = reinterpret_cast<Tuple*>(new_tuple);
-
+ if (dst_tuples[j] == nullptr) {
+ int size = row_batch->capacity() * (*dst_it)->byte_size();
Review comment:
the memory of dst_tuples[j] is all the memory of jth tuple in the row batch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #2858: fix core
when using grouping sets in large data
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #2858: fix core when using grouping sets in large data
URL: https://github.com/apache/incubator-doris/pull/2858
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] lingbin commented on a change in pull request
#2858: fix core when using grouping sets in large data
Posted by GitBox <gi...@apache.org>.
lingbin commented on a change in pull request #2858: fix core when using grouping sets in large data
URL: https://github.com/apache/incubator-doris/pull/2858#discussion_r376358569
##########
File path: be/src/exec/repeat_node.cpp
##########
@@ -100,10 +93,18 @@ Status RepeatNode::get_repeated_batch(
continue;
}
- char* new_tuple = reinterpret_cast<char*>(dst_tuples[j]);
- new_tuple += (*dst_it)->byte_size();
- dst_tuples[j] = reinterpret_cast<Tuple*>(new_tuple);
-
+ if (dst_tuples[j] == nullptr) {
+ int size = row_batch->capacity() * (*dst_it)->byte_size();
Review comment:
is it a typo? should we use row_batch's capacity to calculate one tuple's memory size?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org