[jira] [Comment Edited] (HADOOP-18435) Remove usage of fs.s3a.executor.capacity

["Viraj Jasani (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-18435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599093#comment-17599093 ] 

Viraj Jasani edited comment on HADOOP-18435 at 9/1/22 5:34 PM:
---------------------------------------------------------------

To be more specific, the below mentioned method is no longer in use, making this config (fs.s3a.executor.capacity) not usable by any consumer. That's why having the config's existence in codebase as well as default site config would make any user try configuring it's value but it won't have any impact in reality.
{code:java}
/**
 * Create a new executor with the capacity defined in
 * {@link #executorCapacity}.
 * @return a new executor for exclusive use by the caller.
 */
public ExecutorService createThrottledExecutor() {
  return createThrottledExecutor(executorCapacity);
} {code}


was (Author: vjasani):
To be more specific, this method is no longer in use, making this config not usable by any consumer. That's why having the config's existence in codebase as well as default site config would make any user try configuring it's value but it won't have any impact in reality.
{code:java}
/**
 * Create a new executor with the capacity defined in
 * {@link #executorCapacity}.
 * @return a new executor for exclusive use by the caller.
 */
public ExecutorService createThrottledExecutor() {
  return createThrottledExecutor(executorCapacity);
} {code}

> Remove usage of fs.s3a.executor.capacity
> ----------------------------------------
>
>                 Key: HADOOP-18435
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18435
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>
> When s3guard was part of s3a, DynamoDBMetadataStore was the only consumer of StoreContext that used throttled executor provided by StoreContext, which internally uses fs.s3a.executor.capacity to determine executor capacity for SemaphoredDelegatingExecutor. With the removal of s3guard from s3a, we should also remove fs.s3a.executor.capacity and it's usages as it's no longer being used by any StoreContext consumers. The config's existence and its description can be really confusing for the users.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org