You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "hujun260 (via GitHub)" <gi...@apache.org> on 2023/09/18 06:30:42 UTC
[GitHub] [nuttx] hujun260 opened a new pull request, #10683: pthread_cleanup: rm sched_[un]lock
hujun260 opened a new pull request, #10683:
URL: https://github.com/apache/nuttx/pull/10683
## Summary
Since TLS is only used within a single thread and requires no additional protection.
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #10683: pthread_cleanup: rm sched_[un]lock
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #10683:
URL: https://github.com/apache/nuttx/pull/10683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on pull request #10683: pthread_cleanup: rm sched_[un]lock
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on PR #10683:
URL: https://github.com/apache/nuttx/pull/10683#issuecomment-1722910655
Please rebase the change to fix CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #10683: pthread_cleanup: rm sched_[un]lock
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #10683:
URL: https://github.com/apache/nuttx/pull/10683#discussion_r1328358393
##########
libs/libc/pthread/pthread_cleanup.c:
##########
@@ -139,12 +139,6 @@ void pthread_cleanup_push(pthread_cleanup_t routine, FAR void *arg)
DEBUGASSERT(tls != NULL);
DEBUGASSERT(tls->tos < CONFIG_PTHREAD_CLEANUP_STACKSIZE);
- /* sched_lock() should provide sufficient protection. We only need to
- * have this TCB stationary; the pthread cleanup stack should never be
- * modified by interrupt level logic.
- */
-
- sched_lock();
Review Comment:
What about `pthread_cleanup_pop` and `pthread_cleanup_popall`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org