You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/11/16 11:08:16 UTC
[GitHub] [camel] ex324 opened a new pull request #4614: CAMEL-15858: Adds feature for remote file handling for OpenAPI specifications
ex324 opened a new pull request #4614:
URL: https://github.com/apache/camel/pull/4614
This pull request adds support for using remote OpenAPI specifications.
The implementation uses the existing _specificationUri_ attribute of the plugin allowing the usage of http-URLs additionaly to only looking in the local file system.
The implementation additionally adds a new _auth_ attribute to pass an authorization header. It's usage is added to the plugin documentation.
The code is copied from the OpenAPITools (https://github.com/OpenAPITools/openapi-generator) **openapi-generator-maven-plugin**, so the implementation adds a new maven dependency for the _openapi-generator_.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a change in pull request #4614: CAMEL-15858: Adds feature for remote file handling for OpenAPI specifications
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #4614:
URL: https://github.com/apache/camel/pull/4614#discussion_r527550055
##########
File path: tooling/maven/camel-restdsl-openapi-plugin/src/main/java/org/apache/camel/maven/generator/openapi/AbstractGenerateMojo.java
##########
@@ -33,6 +40,7 @@
import com.fasterxml.jackson.databind.ObjectMapper;
import io.apicurio.datamodels.Library;
import io.apicurio.datamodels.openapi.models.OasDocument;
+import io.swagger.v3.parser.core.models.AuthorizationValue;
Review comment:
Can we avoid swagger imports, as we should ideally only use the datamodel from apicurio.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a change in pull request #4614: CAMEL-15858: Adds feature for remote file handling for OpenAPI specifications
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #4614:
URL: https://github.com/apache/camel/pull/4614#discussion_r524927558
##########
File path: tooling/maven/camel-restdsl-openapi-plugin/pom.xml
##########
@@ -55,6 +55,11 @@
<artifactId>snakeyaml</artifactId>
<version>${snakeyaml-version}</version>
</dependency>
+ <dependency>
+ <groupId>org.openapitools</groupId>
+ <artifactId>openapi-generator</artifactId>
+ <version>4.3.1</version>
Review comment:
Morning. I meant here: https://github.com/apache/camel/blob/master/parent/pom.xml
##########
File path: tooling/maven/camel-restdsl-openapi-plugin/pom.xml
##########
@@ -55,6 +55,11 @@
<artifactId>snakeyaml</artifactId>
<version>${snakeyaml-version}</version>
</dependency>
+ <dependency>
+ <groupId>org.openapitools</groupId>
+ <artifactId>openapi-generator</artifactId>
+ <version>4.3.1</version>
Review comment:
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4614: CAMEL-15858: Adds feature for remote file handling for OpenAPI specifications
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4614:
URL: https://github.com/apache/camel/pull/4614#issuecomment-732127745
LGTM, lets wait for @davsclaus
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4614: CAMEL-15858: Adds feature for remote file handling for OpenAPI specifications
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4614:
URL: https://github.com/apache/camel/pull/4614#issuecomment-732014018
This is still pending.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4614: CAMEL-15858: Adds feature for remote file handling for OpenAPI specifications
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4614:
URL: https://github.com/apache/camel/pull/4614#issuecomment-732021741
I think you need to rebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ex324 commented on a change in pull request #4614: CAMEL-15858: Adds feature for remote file handling for OpenAPI specifications
Posted by GitBox <gi...@apache.org>.
ex324 commented on a change in pull request #4614:
URL: https://github.com/apache/camel/pull/4614#discussion_r524922944
##########
File path: tooling/maven/camel-restdsl-openapi-plugin/pom.xml
##########
@@ -55,6 +55,11 @@
<artifactId>snakeyaml</artifactId>
<version>${snakeyaml-version}</version>
</dependency>
+ <dependency>
+ <groupId>org.openapitools</groupId>
+ <artifactId>openapi-generator</artifactId>
+ <version>4.3.1</version>
Review comment:
Hi. Thanks for the input. Would you like the according property in the maven-plugins pom or in another, e.g. tooling-parent pom?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a change in pull request #4614: CAMEL-15858: Adds feature for remote file handling for OpenAPI specifications
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #4614:
URL: https://github.com/apache/camel/pull/4614#discussion_r524359956
##########
File path: tooling/maven/camel-restdsl-openapi-plugin/pom.xml
##########
@@ -55,6 +55,11 @@
<artifactId>snakeyaml</artifactId>
<version>${snakeyaml-version}</version>
</dependency>
+ <dependency>
+ <groupId>org.openapitools</groupId>
+ <artifactId>openapi-generator</artifactId>
+ <version>4.3.1</version>
Review comment:
This can be a placeholder for property version in parent/pom
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ex324 commented on a change in pull request #4614: CAMEL-15858: Adds feature for remote file handling for OpenAPI specifications
Posted by GitBox <gi...@apache.org>.
ex324 commented on a change in pull request #4614:
URL: https://github.com/apache/camel/pull/4614#discussion_r528648087
##########
File path: tooling/maven/camel-restdsl-openapi-plugin/src/main/java/org/apache/camel/maven/generator/openapi/AbstractGenerateMojo.java
##########
@@ -33,6 +40,7 @@
import com.fasterxml.jackson.databind.ObjectMapper;
import io.apicurio.datamodels.Library;
import io.apicurio.datamodels.openapi.models.OasDocument;
+import io.swagger.v3.parser.core.models.AuthorizationValue;
Review comment:
I removed the openapi / swagger dependencies...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd merged pull request #4614: CAMEL-15858: Adds feature for remote file handling for OpenAPI specifications
Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #4614:
URL: https://github.com/apache/camel/pull/4614
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org