You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by ch...@apache.org on 2021/02/02 05:48:01 UTC

[incubator-dolphinscheduler] branch dev updated: fix ui local param plugin do not display input.

This is an automated email from the ASF dual-hosted git repository.

chenxingchun pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
     new 1c4343a  fix ui local param plugin do not display input.
     new cfd9db5  Merge pull request #4658 from zhuangchong/dev-fix-localparam-input-display
1c4343a is described below

commit 1c4343ae296bea6fe23739a7612acaad04ac6304
Author: zhuangchong <zh...@163.com>
AuthorDate: Tue Feb 2 13:10:52 2021 +0800

    fix ui local param plugin do not display input.
---
 .../dag/_source/formModel/tasks/_source/localParams.vue      | 12 ++++--------
 .../projects/pages/definition/pages/list/_source/start.vue   |  3 +--
 2 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/_source/localParams.vue b/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/_source/localParams.vue
index c8a600b..c001a20 100644
--- a/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/_source/localParams.vue
+++ b/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/_source/localParams.vue
@@ -59,7 +59,7 @@
         </el-select>
       </template>
       <el-input
-              :disabled="isDetails && !isStartProcess"
+              :disabled="isDetails"
               type="text"
               size="small"
               v-model="localParamsList[$index].value"
@@ -68,18 +68,18 @@
               @blur="_handleValue()"
               :style="inputStyle">
       </el-input>
-      <span class="lt-add" v-show="!isStartProcess">
+      <span class="lt-add">
         <a href="javascript:" style="color:red;" @click="!isDetails && _removeUdp($index)" >
           <em class="el-icon-delete" :class="_isDetails" data-toggle="tooltip" :title="$t('delete')" ></em>
         </a>
       </span>
-      <span class="add" v-if="$index === (localParamsList.length - 1)" v-show="!isStartProcess">
+      <span class="add" v-if="$index === (localParamsList.length - 1)">
         <a href="javascript:" @click="!isDetails && _addUdp()" >
           <em class="el-icon-circle-plus-outline" :class="_isDetails" data-toggle="tooltip" :title="$t('Add')"></em>
         </a>
       </span>
     </div>
-    <span class="add-dp" v-if="!localParamsList.length" v-show="isStartProcess">
+    <span class="add-dp" v-if="!localParamsList.length">
       <a href="javascript:" @click="!isDetails && _addUdp()" >
         <em class="iconfont el-icon-circle-plus-outline" :class="_isDetails" data-toggle="tooltip" :title="$t('Add')"></em>
       </a>
@@ -112,10 +112,6 @@
       hide: {
         type: Boolean,
         default: true
-      },
-      isStartProcess: {
-        type: Boolean,
-        default: false
       }
     },
     methods: {
diff --git a/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/_source/start.vue b/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/_source/start.vue
index e9f615d..d6aeaf9 100644
--- a/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/_source/start.vue
+++ b/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/_source/start.vue
@@ -120,8 +120,7 @@
                   ref="refLocalParams"
                   @on-local-params="_onLocalParams"
                   :udp-list="udpList"
-                  :hide="false"
-                  :isStartProcess="true">
+                  :hide="false">
           </m-local-params>
         </div>
       </div>