You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2022/09/07 08:27:05 UTC
[GitHub] [bigtop] kevinw66 opened a new pull request, #1004: BIGTOP-3806: Support parent directory configuration for Flink rpm build script
kevinw66 opened a new pull request, #1004:
URL: https://github.com/apache/bigtop/pull/1004
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g., 'BIGTOP-3638: Your PR title ...'.
-->
### Description of PR
### How was this patch tested?
diff result:
```
414098 blocks
414098 blocks
10 blocks
10 blocks
10 blocks
10 blocks
```
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
- [ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn commented on pull request #1004: BIGTOP-3806: Support parent directory configuration for Flink rpm build script
Posted by GitBox <gi...@apache.org>.
sekikn commented on PR #1004:
URL: https://github.com/apache/bigtop/pull/1004#issuecomment-1243773388
+1. There's no difference between the contents of the original and patched version (without the `parentDir` option). Also, the latter passed the smoke test:
```
[vagrant@rocky8 bigtop]$ ./gradlew allclean hadoop-pkg flink-pkg -Dbuildwithdeps=true
...
BUILD SUCCESSFUL in 1h 1m 26s
72 actionable tasks: 72 executed
[vagrant@rocky8 bigtop]$ mv output/flink ~
[vagrant@rocky8 bigtop]$ curl -sL https://github.com/apache/bigtop/pull/1004.patch | git apply
[vagrant@rocky8 bigtop]$ git diff --stat
bigtop-packages/src/common/flink/install_flink.sh | 45 ++++++++++++++++++++++++++++++---------------
bigtop-packages/src/rpm/flink/SPECS/flink.spec | 52 +++++++++++++++++++++++++++++++++++++---------------
2 files changed, 67 insertions(+), 30 deletions(-)
[vagrant@rocky8 bigtop]$ ./gradlew flink-clean flink-pkg repo
...
BUILD SUCCESSFUL in 28m 9s
9 actionable tasks: 9 executed
[vagrant@rocky8 bigtop]$ for i in $(ls output/flink/noarch); do diff <(rpm -qlp output/flink/noarch/$i) <(rpm -qlp ~/flink/noarch/$i); done
[vagrant@rocky8 bigtop]$ cd provisioner/docker
[vagrant@rocky8 docker]$ ./docker-hadoop.sh -d -C config_rockylinux-8.yaml -r file:///bigtop-home/output -G -k hdfs,flink -s flink -c 3
...
> Task :bigtop-tests:smoke-tests:flink:test
Finished generating test XML results (0.01 secs) into: /bigtop-home/bigtop-tests/smoke-tests/flink/build/test-results/test
Generating HTML test report...
Finished generating test html results (0.017 secs) into: /bigtop-home/bigtop-tests/smoke-tests/flink/build/reports/tests/test
Now testing...
:bigtop-tests:smoke-tests:flink:test (Thread[Daemon worker,5,main]) completed. Took 15.07 secs.
BUILD SUCCESSFUL in 1m 30s
30 actionable tasks: 7 executed, 23 up-to-date
```
The `parentDir` option seems to work as expected, too.
```
[vagrant@rocky8 bigtop]$ ./gradlew flink-clean flink-pkg -PparentDir=/usr/bigtop
...
BUILD SUCCESSFUL in 20m 44s
7 actionable tasks: 7 executed
[vagrant@rocky8 bigtop]$ for i in $(ls output/flink/noarch); do echo $i; rpm -qlpv output/flink/noarch/$i; echo; done
flink-1.15.0-1.el8.noarch.rpm
drwxr-xr-x 2 flink flink 0 Sep 12 13:18 /etc/flink
drwxr-xr-x 2 root root 0 Sep 12 13:18 /usr/bigtop/etc/flink/conf.dist
...
-rw-r--r-- 1 root root 1434 Apr 20 17:50 /usr/bigtop/etc/flink/conf.dist/zoo.cfg
-rwxr-xr-x 1 root root 469 Sep 12 13:18 /usr/bigtop/usr/bin/flink
drwxr-xr-x 2 root root 0 Sep 12 13:18 /usr/bigtop/usr/lib/flink
...
-rw-r--r-- 1 root root 24279 Jul 2 14:47 /usr/bigtop/usr/lib/flink/lib/log4j-slf4j-impl-2.17.1.jar
drwxr-xr-x 2 flink flink 0 Sep 12 13:18 /var/log/flink
drwxrw-rwx 2 flink flink 0 Sep 12 13:18 /var/log/flink-cli
flink-jobmanager-1.15.0-1.el8.noarch.rpm
-rwxr-xr-x 1 root root 4735 Sep 12 13:18 /etc/rc.d/init.d/flink-jobmanager
flink-taskmanager-1.15.0-1.el8.noarch.rpm
-rwxr-xr-x 1 root root 4706 Sep 12 13:18 /etc/rc.d/init.d/flink-taskmanager
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn merged pull request #1004: BIGTOP-3806: Support parent directory configuration for Flink rpm build script
Posted by GitBox <gi...@apache.org>.
sekikn merged PR #1004:
URL: https://github.com/apache/bigtop/pull/1004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn commented on pull request #1004: BIGTOP-3806: Support parent directory configuration for Flink rpm build script
Posted by GitBox <gi...@apache.org>.
sekikn commented on PR #1004:
URL: https://github.com/apache/bigtop/pull/1004#issuecomment-1243773957
Merged into master. Thanks @kevinw66!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org