You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by ni...@apache.org on 2013/05/16 23:27:17 UTC
svn commit: r1483573 - /logging/log4j/log4j2/trunk/checkstyle.xml
Author: nickwilliams
Date: Thu May 16 21:27:17 2013
New Revision: 1483573
URL: http://svn.apache.org/r1483573
Log:
Per discussion on mailing list, updating CheckStyle rules to enforce import order.
Modified:
logging/log4j/log4j2/trunk/checkstyle.xml
Modified: logging/log4j/log4j2/trunk/checkstyle.xml
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/checkstyle.xml?rev=1483573&r1=1483572&r2=1483573&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/checkstyle.xml (original)
+++ logging/log4j/log4j2/trunk/checkstyle.xml Thu May 16 21:27:17 2013
@@ -114,13 +114,29 @@
<!-- Checks for imports -->
<!-- See http://checkstyle.sf.net/config_import.html -->
- <module name="AvoidStarImport"/>
- <module name="IllegalImport"/> <!-- defaults to sun.* packages -->
+ <module name="AvoidStarImport">
+ <property name="allowStaticMemberImports" value="true"/>
+ </module>
+ <module name="IllegalImport"/><!-- defaults to sun.* packages -->
<module name="RedundantImport"/>
<module name="UnusedImports"/>
<module name="ImportControl">
- <property name="severity" value="error"/>
- <property name="file" value="checkstyle-import-control.xml"/>
+ <property name="severity" value="error"/>
+ <property name="file" value="checkstyle-import-control.xml"/>
+ </module>
+ <module name="ImportOrder">
+ <!-- Imports must be separated (by one newline) into the following groups:
+ java and javax
+ org
+ com
+ all others
+ Imports within a group must be sorted alphabetically (lexicographically)
+ All static imports come below all other imports -->
+ <property name="groups" value="/^javax?\./,org,com"/>
+ <property name="ordered" value="true"/>
+ <property name="caseSensitive" value="true"/>
+ <property name="separated" value="true"/>
+ <property name="option" value="bottom"/>
</module>