You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Konrad Windszus (Jira)" <ji...@apache.org> on 2023/12/08 15:36:00 UTC

[jira] [Commented] (SLING-12186) Automatic code formatting with spotless-maven-plugin

    [ https://issues.apache.org/jira/browse/SLING-12186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794776#comment-17794776 ] 

Konrad Windszus commented on SLING-12186:
-----------------------------------------

There are two PoC branches where proposed formatting rules have been applied:

# https://github.com/apache/sling-org-apache-sling-models-api/pull/11
# https://github.com/apache/sling-org-apache-sling-models-impl/pull/48

> Automatic code formatting with spotless-maven-plugin
> ----------------------------------------------------
>
>                 Key: SLING-12186
>                 URL: https://issues.apache.org/jira/browse/SLING-12186
>             Project: Sling
>          Issue Type: Improvement
>          Components: General
>            Reporter: Konrad Windszus
>            Priority: Major
>
> As discussed in https://lists.apache.org/thread/t32o425mttoftfr622wkvp4s5br4wzt1 we should introduce [spotless-maven-plugin|https://github.com/diffplug/spotless/tree/main/plugin-maven] to enforce a common code formatting similar to what was done for Maven in https://issues.apache.org/jira/browse/MPOM-349.
> With each reformatting a {{.git-blame-ignore-revs}} should be added/enriched which is considered by git blame in GitHub (https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view) and optionally with Git CLI (https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt). 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)