You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/23 10:50:14 UTC

[GitHub] [incubator-nuttx] fjpanag commented on issue #3599: Syslog thread-safety

fjpanag commented on issue #3599:
URL: https://github.com/apache/incubator-nuttx/issues/3599#issuecomment-825574324


   > semaphore isn't enough here, we need the critical section to sync with the interrupt handle. Since the critical section will block all hardware interrupt process, and the serial is very slow, the lock will make a significant impact on the runtime behaviour.
   
   Indeed a critical section would be a problem.  
   But I guess the semaphore isn't needed to be held by the interrupts. The interrupts can continue logging in the int buffer.
   
   The interrupts buffer may remain as is, since there is no nesting for interrupts. Its only the threads that need to be protected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org