You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by olegz <gi...@git.apache.org> on 2017/01/23 02:54:09 UTC

[GitHub] nifi pull request #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON tr...

GitHub user olegz opened a pull request:

    https://github.com/apache/nifi/pull/1436

    NIFI-3354 Added support for simple AVRO/CSV/JSON transformers that ut\u2026

    \u2026ilize external Schema
    
    Added support for simple Key/Value Schema Registry as Controller Service
    Added support for registering multiple schemas as dynamic properties of Schema Registry  Controller Service
    Added the following 8 processors
    - ExtractAvroFieldsViaSchemaRegistry
    - TransformAvroToCSVViaSchemaRegistry
    - TransformAvroToJsonViaSchemaRegistry
    - TransformCSVToAvroViaSchemaRegistry
    - TransformCSVToJsonViaSchemaRegistry
    - TransformJsonToAvroViaSchemaRegistry
    - TransformJsonToCSVViaSchemaRegistry
    - UpdateAttributeWithSchemaViaSchemaRegistry
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/olegz/nifi NIFI-3354

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1436.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1436
    
----
commit e4fda15f573a8ff4a40b0e98dab5833ef9c6c7f5
Author: Oleg Zhurakousky <ol...@suitcase.io>
Date:   2017-01-20T15:04:48Z

    NIFI-3354 Added support for simple AVRO/CSV/JSON transformers that utilize external Schema
    Added support for simple Key/Value Schema Registry as Controller Service
    Added support for registering multiple schemas as dynamic properties of Schema Registry  Controller Service
    Added the following 8 processors
    - ExtractAvroFieldsViaSchemaRegistry
    - TransformAvroToCSVViaSchemaRegistry
    - TransformAvroToJsonViaSchemaRegistry
    - TransformCSVToAvroViaSchemaRegistry
    - TransformCSVToJsonViaSchemaRegistry
    - TransformJsonToAvroViaSchemaRegistry
    - TransformJsonToCSVViaSchemaRegistry
    - UpdateAttributeWithSchemaViaSchemaRegistry

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:

    https://github.com/apache/nifi/pull/1436
  
    Also the nifi-registry-nar LICENSE and NOTICE file needs a lot of work.  This thing has a lot of dependencies.  Take a look at the hadoop nar LICENSE/NOTICE to get started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:

    https://github.com/apache/nifi/pull/1436
  
    Also can you grab this dataset http://standards.ieee.org/develop/regauth/oui/oui.csv and show what the schema would be to parse it and use CSVtoJson to convert it?  I was getting errors.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON tr...

Posted by olegz <gi...@git.apache.org>.
Github user olegz closed the pull request at:

    https://github.com/apache/nifi/pull/1436


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON tr...

Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1436#discussion_r99842926
  
    --- Diff: nifi-nar-bundles/nifi-registry-bundle/nifi-registry-processors/src/main/java/org/apache/nifi/schemaregistry/processors/AbstractCSVTransformerViaRegistryProcessor.java ---
    @@ -0,0 +1,57 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.schemaregistry.processors;
    +
    +import java.util.ArrayList;
    +import java.util.Collections;
    +import java.util.List;
    +
    +import org.apache.nifi.annotation.lifecycle.OnScheduled;
    +import org.apache.nifi.components.PropertyDescriptor;
    +import org.apache.nifi.processor.ProcessContext;
    +import org.apache.nifi.schemaregistry.services.SchemaRegistry;
    +
    +/**
    + * Base processor for implementing transform-like processors for CSV
    + * transformations that integrate with Schema Registry (see
    + * {@link SchemaRegistry})
    + */
    +abstract class AbstractCSVTransformerViaRegistryProcessor extends BaseContentTransformerViaSchemaRegistry {
    +
    +    static final List<PropertyDescriptor> BASE_CSV_DESCRIPTORS;
    +
    +    static {
    +        List<PropertyDescriptor> descriptors = new ArrayList<PropertyDescriptor>();
    +        descriptors.addAll(BASE_DESCRIPTORS);
    +        descriptors.add(DELIMITER);
    +        BASE_CSV_DESCRIPTORS = Collections.unmodifiableList(descriptors);
    +    }
    +
    +    protected volatile char delimiter;
    +
    +    @Override
    +    public List<PropertyDescriptor> getSupportedPropertyDescriptors() {
    +        return BASE_CSV_DESCRIPTORS;
    +    }
    +
    +    @Override
    +    @OnScheduled
    +    public void onScheduled(ProcessContext context) {
    +        super.onScheduled(context);
    +        this.delimiter = context.getProperty(DELIMITER).getValue().charAt(0);
    --- End diff --
    
    Very valid point. Thanks for bringing this up and indeed we do have utility class that parses based on multi-char delimiters. Will make that happen. Once again, thanks for bringing this up


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the issue:

    https://github.com/apache/nifi/pull/1436
  
    @joewitt copyrights are fixed. Please see the latest commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:

    https://github.com/apache/nifi/pull/1436
  
    Oleg
    
    the license/notice of the nar needs to cover
    
    avro/jackson/commons compress/paranamer/snappy
    
    All of these already elsewhere in license/notice as needed so should be a simple copy/paste.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:

    https://github.com/apache/nifi/pull/1436
  
    some of the source files have headers referencing hortonworks copyright.  That is either a copy/paste issue and just needs to be fixed or it is not an original work for apache nifi and will need to go through the ip clearance process.  can you please clarify and/or adjust.  thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:

    https://github.com/apache/nifi/pull/1436
  
    OK - so these processors should support input data with multiple events.  Going from CSV to JSON should allow CSV input to have multiple rows and it would output an array of JSON objects.  Going from CSV to Avro should do the same but in avro friendly way.  Etc.. This avoids the need for splitting cases.
    
    Can you please raise a JIRA to address this/improve this later?  I think as-is this is quite useful.  Please address the licensing concern and I'll take another look.  If that is sorted I'm a +1 and will merge (please squash the last commits with the licensing fix.
    
    thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:

    https://github.com/apache/nifi/pull/1436
  
    @olegz Can you please address the merge conflict.  Also, i definitely share @mattyb149 view that we "ViaSchemaRegistry" nomenclature is avoidable.  The basename is great.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:

    https://github.com/apache/nifi/pull/1436
  
    Do we need the ViaSchemaRegistry on the names of these processors? Seems like the name without that postfix is still unique, and we don't refer to other controller services in the names of processors that use them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the issue:

    https://github.com/apache/nifi/pull/1436
  
    @joewitt If you were trying to use the linked CSV with the provided template (the one attached in JIRA) it would not work since the template relies on different schema. I need to come up with the  schema for this one


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the issue:

    https://github.com/apache/nifi/pull/1436
  
    Merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:

    https://github.com/apache/nifi/pull/1436
  
    This is really cool and I suspect these processors will get a lot of use.  Some feedback below.
    
    TransformCSVtoJSON: 
    1) It needs to set the content type attribute.  Aids content viewing and routing decisions.  For example
              flowFile = session.putAttribute(flowFile, CoreAttributes.MIME_TYPE.key(), "application/json");
    
    UpdateAttributeWithSchema: 
    1) Recommend changing the name to 'ExtractSchema'.  The name is confusing when you consider 'UpdateAttribute' processor and what that one does (and is very common).
    2) It grabs the schema definition from the registry service and makes that a flow file attribute.  This is problematic if the schema is large.  We do not want large flow file attributes.  So this needs to be limited.  Why is this processor needed?
    
    TransformJSONToAvro:
    1) Needs to set the content type attribute.  According to the latest avro spec it is "avro/binary"
    
    TransformAvroToCSV
    1) Needs to set the content type attribute.  "text/csv"
    
    TransformCSVToAvro
    1) Needs to set the content type attribute.
    
    TransformAvroToJson
    1) Needs to set the content type attribute.
    
    TransformJSONToCSV
    1) Needs to set the content type attribute.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the issue:

    https://github.com/apache/nifi/pull/1436
  
    @joewitt with regard to content type and name change comment, 100% agree. Will make a change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:

    https://github.com/apache/nifi/pull/1436
  
    ok much better now that the hadoop stuff is out.  if that is necessary it could be added as a seperate nar which has this one as its parent.  Glad the extractschema is gone.  Will test again and respond.  thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:

    https://github.com/apache/nifi/pull/1436
  
    @olegz thanks.  can you squash the last two commits.  Don't want em all squashed as would not want it to mess up the psaltis authoriship.  Ultimately it doesn't matter so if you don't want to then so be it :-)  Let me know


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the issue:

    https://github.com/apache/nifi/pull/1436
  
    Agreed about _ ViaSchemaRegistry_


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the issue:

    https://github.com/apache/nifi/pull/1436
  
    @joewitt added new JIRAs to handle multi-line CSV input and multi-char delimiters suggested by @patricker 
    https://issues.apache.org/jira/browse/NIFI-3499
    https://issues.apache.org/jira/browse/NIFI-3500


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:

    https://github.com/apache/nifi/pull/1436
  
    I've attached a template used to validate the behavior.  once licensing/notice is updated I think this is good to go.  In testing this it exposed the issue described and addressed here: https://issues.apache.org/jira/browse/NIFI-3495


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON tr...

Posted by patricker <gi...@git.apache.org>.
Github user patricker commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1436#discussion_r99839940
  
    --- Diff: nifi-nar-bundles/nifi-registry-bundle/nifi-registry-processors/src/main/java/org/apache/nifi/schemaregistry/processors/AbstractCSVTransformerViaRegistryProcessor.java ---
    @@ -0,0 +1,57 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.schemaregistry.processors;
    +
    +import java.util.ArrayList;
    +import java.util.Collections;
    +import java.util.List;
    +
    +import org.apache.nifi.annotation.lifecycle.OnScheduled;
    +import org.apache.nifi.components.PropertyDescriptor;
    +import org.apache.nifi.processor.ProcessContext;
    +import org.apache.nifi.schemaregistry.services.SchemaRegistry;
    +
    +/**
    + * Base processor for implementing transform-like processors for CSV
    + * transformations that integrate with Schema Registry (see
    + * {@link SchemaRegistry})
    + */
    +abstract class AbstractCSVTransformerViaRegistryProcessor extends BaseContentTransformerViaSchemaRegistry {
    +
    +    static final List<PropertyDescriptor> BASE_CSV_DESCRIPTORS;
    +
    +    static {
    +        List<PropertyDescriptor> descriptors = new ArrayList<PropertyDescriptor>();
    +        descriptors.addAll(BASE_DESCRIPTORS);
    +        descriptors.add(DELIMITER);
    +        BASE_CSV_DESCRIPTORS = Collections.unmodifiableList(descriptors);
    +    }
    +
    +    protected volatile char delimiter;
    +
    +    @Override
    +    public List<PropertyDescriptor> getSupportedPropertyDescriptors() {
    +        return BASE_CSV_DESCRIPTORS;
    +    }
    +
    +    @Override
    +    @OnScheduled
    +    public void onScheduled(ProcessContext context) {
    +        super.onScheduled(context);
    +        this.delimiter = context.getProperty(DELIMITER).getValue().charAt(0);
    --- End diff --
    
    Handling DELIMITER like this does not allow for special character delimiters. What about:
    
    `org.apache.commons.lang3.StringEscapeUtils.unescapeJavacontext.getProperty(DELIMITER).getValue()).charAt(0);`
    
    This would allow users to enter delimiters using Java's unicode syntax '\u0001' for example.  Also, who not support multi-character delimiters?  I've found these very useful in my own work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:

    https://github.com/apache/nifi/pull/1436
  
    @olegz thanks for squashing.  Am reviewing.  Corrected the simple merge conflict locally.  Will advise once build completes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the issue:

    https://github.com/apache/nifi/pull/1436
  
    @joewitt Thanks Joe. That was indeed copy/paste issue from unrelated internal effort. Will fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:

    https://github.com/apache/nifi/pull/1436
  
    ok Oleg.  Thanks!  Looks great.  +1 please go ahead and squash the commits after psaltis and merge.  Nice job


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---