[GitHub] [spark] grundprinzip commented on a diff in pull request #38166: [SPARK-40713][CONNECT] Improve SET operation support in the proto and the server

[GitBox <gi...@apache.org>]

grundprinzip commented on code in PR #38166:
URL: https://github.com/apache/spark/pull/38166#discussion_r990759375


##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -107,15 +107,17 @@ message Join {
   }
 }
 
-// Relation of type [[Union]], at least one input must be set.

Review Comment:
   TBH i think the comment was not correct in the first place. I mean while a set can have one element, the question is does it make sense to have a set plan with only one?



##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -35,7 +35,7 @@ message Relation {
     Project project = 3;
     Filter filter = 4;
     Join join = 5;
-    Union union = 6;

Review Comment:
   Why is Set better than Union? Just from a SQL naming persepective, Union might be what users are used to?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org