You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/12/09 11:35:51 UTC
[GitHub] [hive] pgaref commented on a change in pull request #1758: HIVE-24504: VectorFileSinkArrowOperator does not serialize complex types correctly
pgaref commented on a change in pull request #1758:
URL: https://github.com/apache/hive/pull/1758#discussion_r539228933
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/io/arrow/TestSerializer.java
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.ql.io.arrow;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.serde2.typeinfo.TypeInfo;
+import org.apache.hadoop.hive.serde2.typeinfo.TypeInfoUtils;
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.Arrays;
+import java.util.List;
+
+public class TestSerializer {
+ @Test
+ public void testEmptyArray() {
Review comment:
Nit: Would probably name it testEmptyList for consistency with the Serializer
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/io/arrow/TestSerializer.java
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.ql.io.arrow;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.serde2.typeinfo.TypeInfo;
+import org.apache.hadoop.hive.serde2.typeinfo.TypeInfoUtils;
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.Arrays;
+import java.util.List;
+
+public class TestSerializer {
+ @Test
+ public void testEmptyArray() {
+ List<TypeInfo> typeInfos = TypeInfoUtils.getTypeInfosFromTypeString("array<tinyint>");
+ List<String> fieldNames = Arrays.asList(new String[]{"a"});
+ Serializer converter = new Serializer(new HiveConf(), "attemptId", typeInfos, fieldNames);
+ ArrowWrapperWritable writable = converter.emptyBatch();
+ Assert.assertEquals("Schema<a: List<$data$: Int(8, true)>>",
+ writable.getVectorSchemaRoot().getSchema().toString());
+ }
+
+ @Test
+ public void testEmptyStruct() {
+ List<TypeInfo> typeInfos = TypeInfoUtils.getTypeInfosFromTypeString("struct<b:int,c:string>");
+ List<String> fieldNames = Arrays.asList(new String[] { "a" });
+ Serializer converter = new Serializer(new HiveConf(), "attemptId", typeInfos, fieldNames);
+ ArrowWrapperWritable writable = converter.emptyBatch();
+ Assert.assertEquals("Schema<a: Struct<b: Int(32, true), c: Utf8>>",
+ writable.getVectorSchemaRoot().getSchema().toString());
+ }
+
+ @Test
+ public void testEmptyMap() {
+ List<TypeInfo> typeInfos = TypeInfoUtils.getTypeInfosFromTypeString("map<string,string>");
+ List<String> fieldNames = Arrays.asList(new String[] { "a" });
+ Serializer converter = new Serializer(new HiveConf(), "attemptId", typeInfos, fieldNames);
+ ArrowWrapperWritable writable = converter.emptyBatch();
+ Assert.assertEquals("Schema<a: List<$data$: Struct<keys: Utf8, values: Utf8>>>",
+ writable.getVectorSchemaRoot().getSchema().toString());
+ }
+
+ @Test
+ public void testEmptyComplexStruct() {
+ List<TypeInfo> typeInfos = TypeInfoUtils.getTypeInfosFromTypeString(
+ "struct<b:array<tinyint>,c:map<string,string>,d:struct<e:array<tinyint>,f:map<string,string>>>");
+ List<String> fieldNames = Arrays.asList(new String[] { "a" });
+ Serializer converter = new Serializer(new HiveConf(), "attemptId", typeInfos, fieldNames);
+ ArrowWrapperWritable writable = converter.emptyBatch();
+ Assert.assertEquals(
+ "Schema<a: Struct<b: List<$data$: Int(8, true)>, c: List<$data$: Struct<keys: Utf8, values: Utf8>>, " +
+ "d: Struct<e: List<$data$: Int(8, true)>, f: List<$data$: Struct<keys: Utf8, values: Utf8>>>>>",
+ writable.getVectorSchemaRoot().getSchema().toString());
+ }
Review comment:
Would it make sense to test nested types here as well? like list<list> ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org