[jira] [Commented] (FLINK-9358) Closing of unestablished RM connections can cause NPE

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474119#comment-16474119 ] 

ASF GitHub Bot commented on FLINK-9358:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/6011

    [FLINK-9358] Avoid NPE when closing an unestablished ResourceManager connection

    ## What is the purpose of the change
    
    A NPE occurred when trying to disconnect an unestablished ResourceManager connection.
    In order to fix this problem, we now check whether the connection has been established
    or not.
    
    ## Verifying this change
    
    - Added `JobMasterTest#testCloseUnestablishedResourceManagerConnection`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink properlyCloseRMConnection

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6011.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6011
    
----
commit 459d8da472de77eef862e331765ea7eb5a6cf2e1
Author: Till Rohrmann <tr...@...>
Date:   2018-05-14T12:14:45Z

    [FLINK-9358] Avoid NPE when closing an unestablished ResourceManager connection
    
    A NPE occurred when trying to disconnect an unestablished ResourceManager connection.
    In order to fix this problem, we now check whether the connection has been established
    or not.

----


> Closing of unestablished RM connections can cause NPE
> -----------------------------------------------------
>
>                 Key: FLINK-9358
>                 URL: https://issues.apache.org/jira/browse/FLINK-9358
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Blocker
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> When closing an unestablished RM connection, a NPE is thrown. The reason is that we try to unmonitor a non-existing heartbeat target.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)