You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/20 17:09:45 UTC

[GitHub] [pulsar-client-go] merlimat commented on issue #500: Make Topic Level Prometheus Metrics Optional

merlimat commented on issue #500:
URL: https://github.com/apache/pulsar-client-go/issues/500#issuecomment-823453420


   @michaeljmarshall Missed your comment earlier. I don't think it would be hard to add the configuration. 
   
   We'd just need some kind of enum setting in the `ClientOptions` to select the appropriate level of metric. 
   
   Right now the labels selected are: https://github.com/apache/pulsar-client-go/blob/ec40d795841b1d61f7cbb07fad08e3c587db8801/pulsar/internal/metrics.go#L24
   
   I believe, with just few adjustments it should be possible disable different labels. 
   Eg:  we could have an enum like : 
   
   ```go
   type MetricsCardinality int
   
   const (
   	Namespace MetricsCardinality = iota // Default value
   	Tenant
   	Topic
           None
   )
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org