You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/09/01 16:21:09 UTC
Re: Review Request 37827: Added a test for converting JSON arrays to
repeated protobufs.
> On Aug. 27, 2015, 5:51 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp, lines 179-181
> > <https://reviews.apache.org/r/37827/diff/2/?file=1055718#file1055718line179>
> >
> > From the method name, I think it's not completely obvious what the type is.
> >
> > Since I wouldn't want to type `Try<google::protobuf::RepeatedPtrField<T>>` either, you could consider renaming to something like `protobuf::parseRepeated<T>`.
>
> Alexander Rukletsov wrote:
> We can do that. If we rename it to `parseRepeated()` we can even change the signature to take `JSON::Object` as a parameter.
Decided to take another approach here, see previous review in the chain.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37827/#review96713
-----------------------------------------------------------
On Aug. 27, 2015, 3:38 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37827/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 3:38 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3312
> https://issues.apache.org/jira/browse/MESOS-3312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp c56d6a3098293eb3659b3066f10e875927ec3ac3
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h cfc2803e42284f641879fb24bce1282215c8ea52
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc a1d4084661345f9367c75f9db61279f032b93e69
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto bbd36d39e9588eb8eea6d739451ad3bab029ca08
>
> Diff: https://reviews.apache.org/r/37827/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.10.4)
>
> **NOTE**: Filed [MESOS-3323](https://issues.apache.org/jira/browse/MESOS-3323) to clean up protobuf generation.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>