[GitHub] [logging-log4cxx] swebb2066 commented on pull request #73: Throughput tests

[GitBox <gi...@apache.org>]

swebb2066 commented on pull request #73:
URL: https://github.com/apache/logging-log4cxx/pull/73#issuecomment-947167006


   It is a benchmarking thing. Your benchmarking tools look good. When are you thinking you will merge?
   
   Have you run the benchmarks without the std::mutex lock in Hierarchy::isDisabled()? (I do not think that lock is necessary as it is only a read)
   
   ________________________________
   From: Robert Middleton ***@***.***>
   Sent: Wednesday, October 20, 2021 9:33 AM
   To: apache/logging-log4cxx ***@***.***>
   Cc: Stephen Webb ***@***.***>; Author ***@***.***>
   Subject: Re: [apache/logging-log4cxx] Throughput tests (PR #73)
   
   
   Is the objective to have a unit test, or a benchmarking test? Those are two somewhat differing goals in my mind - a unit test makes sure that things are working, while a benchmarking test shows how fast under ideal circumstances. Doing this as a unit test doesn't make much sense to me, since it really doesn't test much in terms of a regression.
   
   FWIW here's my repo with my benchmarking tools; at some point I do want to merge it in to do continuous benchmarking tests: https://github.com/rm5248/log4cxx-bench
   
   —
   You are receiving this because you authored the thread.
   Reply to this email directly, view it on GitHub<https://github.com/apache/logging-log4cxx/pull/73#issuecomment-947155410>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADJDRC7R7Y7V773C6FCQA4LUHXW4NANCNFSM5GIYCHEA>.
   Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org