You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "cziegeler (via GitHub)" <gi...@apache.org> on 2025/04/02 07:06:07 UTC
[PR] FELIX-6761 : NullPointerException when registering a new servlet [felix-dev]
cziegeler opened a new pull request, #399:
URL: https://github.com/apache/felix-dev/pull/399
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FELIX-6761 : NullPointerException when registering a new servlet [felix-dev]
Posted by "paulrutter (via GitHub)" <gi...@apache.org>.
paulrutter commented on PR #399:
URL: https://github.com/apache/felix-dev/pull/399#issuecomment-2771613171
@cziegeler I checked out the changes, but i see the WS related unit test now fails.
To your points:
* it does not check that getting the servlet might result in null -> this is clear
* it gets the servlets twice, at least in the case of normal whiteboard handling -> clear, but the behavior is not the same as before
The unit tests fail now:
```
[INFO]
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR] JettySpecificWebsocketIT.testWebSocketServletWhiteboard ┬╗ Upgrade Failed to upgrade to websocket: Unexpected HTTP Response Status Code: 500 Server Error
[INFO]
[ERROR] Tests run: 10, Failures: 0, Errors: 1, Skipped: 0
[INFO]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FELIX-6761 : NullPointerException when registering a new servlet [felix-dev]
Posted by "paulrutter (via GitHub)" <gi...@apache.org>.
paulrutter commented on PR #399:
URL: https://github.com/apache/felix-dev/pull/399#issuecomment-2771777715
@cziegeler I fixed it in https://github.com/apache/felix-dev/pull/399/commits/34ec76fcc99a3cad2ed6cdece5a57c74e128a0c5, the unit tests pass now 👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FELIX-6761 : NullPointerException when registering a new servlet [felix-dev]
Posted by "paulrutter (via GitHub)" <gi...@apache.org>.
paulrutter commented on PR #399:
URL: https://github.com/apache/felix-dev/pull/399#issuecomment-2771799561
@cziegeler ps. in which situation did the NPE actually occur? I haven't run into this myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FELIX-6761 : NullPointerException when registering a new servlet [felix-dev]
Posted by "paulrutter (via GitHub)" <gi...@apache.org>.
paulrutter commented on PR #399:
URL: https://github.com/apache/felix-dev/pull/399#issuecomment-2771793454
LGTM 👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FELIX-6761 : NullPointerException when registering a new servlet [felix-dev]
Posted by "paulrutter (via GitHub)" <gi...@apache.org>.
paulrutter commented on PR #399:
URL: https://github.com/apache/felix-dev/pull/399#issuecomment-2771564264
I will check it out this morning 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FELIX-6761 : NullPointerException when registering a new servlet [felix-dev]
Posted by "cziegeler (via GitHub)" <gi...@apache.org>.
cziegeler merged PR #399:
URL: https://github.com/apache/felix-dev/pull/399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FELIX-6761 : NullPointerException when registering a new servlet [felix-dev]
Posted by "cziegeler (via GitHub)" <gi...@apache.org>.
cziegeler commented on PR #399:
URL: https://github.com/apache/felix-dev/pull/399#issuecomment-2771533994
@paulrutter I merged the two servlet handler classes into a single one to avoid instantiating the servlet object twice (and before init is called)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FELIX-6761 : NullPointerException when registering a new servlet [felix-dev]
Posted by "cziegeler (via GitHub)" <gi...@apache.org>.
cziegeler commented on PR #399:
URL: https://github.com/apache/felix-dev/pull/399#issuecomment-2771789367
@paulrutter Thanks! yes, I forgot to run the tests :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org