You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/12 22:19:59 UTC
[GitHub] [spark] xinrong-databricks opened a new pull request #33307: [SPARK-36104][PYTHON] Manage InternalField in DataTypeOps.neg/abs
xinrong-databricks opened a new pull request #33307:
URL: https://github.com/apache/spark/pull/33307
### What changes were proposed in this pull request?
Manage InternalField for DataTypeOps.neg/abs.
### Why are the changes needed?
The spark data type and nullability must be the same as the original when DataTypeOps.neg/abs.
We should manage InternalField for this case.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33307: [SPARK-36104][PYTHON] Manage InternalField in DataTypeOps.neg/abs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33307:
URL: https://github.com/apache/spark/pull/33307#issuecomment-878639256
**[Test build #140938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140938/testReport)** for PR 33307 at commit [`39ca778`](https://github.com/apache/spark/commit/39ca778ecdd510cd055d60f02b81daa4b912d151).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33307: [SPARK-36104][PYTHON] Manage InternalField in DataTypeOps.neg/abs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33307:
URL: https://github.com/apache/spark/pull/33307#issuecomment-878649543
**[Test build #140938 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140938/testReport)** for PR 33307 at commit [`39ca778`](https://github.com/apache/spark/commit/39ca778ecdd510cd055d60f02b81daa4b912d151).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33307: [SPARK-36104][PYTHON] Manage InternalField in DataTypeOps.neg/abs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33307:
URL: https://github.com/apache/spark/pull/33307#issuecomment-878662959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33307: [SPARK-36104][PYTHON] Manage InternalField in DataTypeOps.neg/abs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33307:
URL: https://github.com/apache/spark/pull/33307#issuecomment-878741636
Merged to master and branch-3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33307: [SPARK-36104][PYTHON] Manage InternalField in DataTypeOps.neg/abs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33307:
URL: https://github.com/apache/spark/pull/33307#issuecomment-878657496
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45450/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33307: [SPARK-36104][PYTHON] Manage InternalField in DataTypeOps.neg/abs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33307:
URL: https://github.com/apache/spark/pull/33307#issuecomment-878639256
**[Test build #140938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140938/testReport)** for PR 33307 at commit [`39ca778`](https://github.com/apache/spark/commit/39ca778ecdd510cd055d60f02b81daa4b912d151).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33307: [SPARK-36104][PYTHON] Manage InternalField in DataTypeOps.neg/abs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33307:
URL: https://github.com/apache/spark/pull/33307#issuecomment-878662959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #33307: [SPARK-36104][PYTHON] Manage InternalField in DataTypeOps.neg/abs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #33307:
URL: https://github.com/apache/spark/pull/33307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org