You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Alejandro Abdelnur <tu...@cloudera.com> on 2011/09/16 04:20:27 UTC
reviewboard patches
As many of you I'm GIT spoiled.
Having the SVN-GIT mirror allows me to continue working with GIT.
The reviewboard tool is currently wired to the SVN repo. Because of this
patches must be SVN like. Git patches are not accepted. This is a bit of a
pain if your are using GIT because you'll have to create the patch in GIT,
apply it locally with 'patch' to SVN and then do 'svn patch' to create the
patch for reviewboard.
I don't know of a a switch in 'git patch' to create a SVN like patch.
If this does not exist one possibility would be:
* switch reviewboard to be wired to GIT.
* developer patch workflow is out of GIT.
* commits are on SVN.
The other possibility is to have an oozie-git repo in reviewboard and
developers will have to use the right project there depending if they are
SVN or GIT.
The later seems a bit confusing thus I'd be a bit more inclined to the
former.
Thoughts?
Thanks.
Alejandro
Re: reviewboard patches
Posted by "Angelo K. Huang" <an...@gmail.com>.
forgot the link:
http://blog.mikepearce.net/2010/09/16/git-svn-and-reviewboard/
On Wed, Oct 5, 2011 at 5:07 PM, Angelo K. Huang <an...@gmail.com>wrote:
> If anyoen looks for solution for this, here is the place. It works for me.
>
> --angelo
>
> On Fri, Sep 16, 2011 at 7:05 PM, Angelo K. Huang <an...@gmail.com>wrote:
>
>> Could you try a java file instead of readme?
>>
>> --angelo
>> On Fri, Sep 16, 2011 at 6:33 PM, Roman Shaposhnik <ro...@shaposhnik.org>wrote:
>>
>>> On Thu, Sep 15, 2011 at 11:28 PM, Alejandro Abdelnur <tu...@gmail.com>
>>> wrote:
>>> > Roman,
>>> >
>>> > git diff --no-prefix works in RB if RB is using a GIT repo for the
>>> > project, if RB is using a SVN repo, it fails. Please try in the Oozie
>>> > RB in apache and you'll see.
>>>
>>> Sure it works!
>>>
>>> Here's how (also works with git-svn)
>>>
>>> $ git clone git://github.com/apache/oozie
>>> $ cd oozie
>>> $ vim readme.txt
>>> $ git diff --no-prefix > /tmp/patch
>>>
>>> Now go to review board: https://reviews.apache.org
>>>
>>> Submit this patch AND DO NOT FORGET to specify trunk
>>> in the Base Directory: field.
>>>
>>> Presto!
>>>
>>> https://reviews.apache.org/r/1942/
>>>
>>> Thanks,
>>> Roman.
>>>
>>
>>
>
Re: reviewboard patches
Posted by "Angelo K. Huang" <an...@gmail.com>.
If anyoen looks for solution for this, here is the place. It works for me.
--angelo
On Fri, Sep 16, 2011 at 7:05 PM, Angelo K. Huang <an...@gmail.com>wrote:
> Could you try a java file instead of readme?
>
> --angelo
> On Fri, Sep 16, 2011 at 6:33 PM, Roman Shaposhnik <ro...@shaposhnik.org>wrote:
>
>> On Thu, Sep 15, 2011 at 11:28 PM, Alejandro Abdelnur <tu...@gmail.com>
>> wrote:
>> > Roman,
>> >
>> > git diff --no-prefix works in RB if RB is using a GIT repo for the
>> > project, if RB is using a SVN repo, it fails. Please try in the Oozie
>> > RB in apache and you'll see.
>>
>> Sure it works!
>>
>> Here's how (also works with git-svn)
>>
>> $ git clone git://github.com/apache/oozie
>> $ cd oozie
>> $ vim readme.txt
>> $ git diff --no-prefix > /tmp/patch
>>
>> Now go to review board: https://reviews.apache.org
>>
>> Submit this patch AND DO NOT FORGET to specify trunk
>> in the Base Directory: field.
>>
>> Presto!
>>
>> https://reviews.apache.org/r/1942/
>>
>> Thanks,
>> Roman.
>>
>
>
Re: reviewboard patches
Posted by "Angelo K. Huang" <an...@gmail.com>.
Could you try a java file instead of readme?
--angelo
On Fri, Sep 16, 2011 at 6:33 PM, Roman Shaposhnik <ro...@shaposhnik.org>wrote:
> On Thu, Sep 15, 2011 at 11:28 PM, Alejandro Abdelnur <tu...@gmail.com>
> wrote:
> > Roman,
> >
> > git diff --no-prefix works in RB if RB is using a GIT repo for the
> > project, if RB is using a SVN repo, it fails. Please try in the Oozie
> > RB in apache and you'll see.
>
> Sure it works!
>
> Here's how (also works with git-svn)
>
> $ git clone git://github.com/apache/oozie
> $ cd oozie
> $ vim readme.txt
> $ git diff --no-prefix > /tmp/patch
>
> Now go to review board: https://reviews.apache.org
>
> Submit this patch AND DO NOT FORGET to specify trunk
> in the Base Directory: field.
>
> Presto!
>
> https://reviews.apache.org/r/1942/
>
> Thanks,
> Roman.
>
Re: reviewboard patches
Posted by Roman Shaposhnik <ro...@shaposhnik.org>.
On Thu, Sep 15, 2011 at 11:28 PM, Alejandro Abdelnur <tu...@gmail.com> wrote:
> Roman,
>
> git diff --no-prefix works in RB if RB is using a GIT repo for the
> project, if RB is using a SVN repo, it fails. Please try in the Oozie
> RB in apache and you'll see.
Sure it works!
Here's how (also works with git-svn)
$ git clone git://github.com/apache/oozie
$ cd oozie
$ vim readme.txt
$ git diff --no-prefix > /tmp/patch
Now go to review board: https://reviews.apache.org
Submit this patch AND DO NOT FORGET to specify trunk
in the Base Directory: field.
Presto!
https://reviews.apache.org/r/1942/
Thanks,
Roman.
Re: reviewboard patches
Posted by Alejandro Abdelnur <tu...@gmail.com>.
Roman,
git diff --no-prefix works in RB if RB is using a GIT repo for the
project, if RB is using a SVN repo, it fails. Please try in the Oozie
RB in apache and you'll see.
Thxs.
Alejandro
On Thu, Sep 15, 2011 at 9:16 PM, Angelo K. Huang <an...@gmail.com> wrote:
> I tried that "git diff --no-prefix", not work for me either.
>
> How to create patch out of 'git svn'? Do you have that similar experience?
>
> --angelo
>
> On Thu, Sep 15, 2011 at 7:49 PM, Roman Shaposhnik <rv...@apache.org> wrote:
>
>> On Thu, Sep 15, 2011 at 7:20 PM, Alejandro Abdelnur <tu...@cloudera.com>
>> wrote:
>> > As many of you I'm GIT spoiled.
>>
>> Aren't we all ;-) In fact I highly advocate using git-svn to work with
>> Apache svn repos -- all the niceties of Git plus direct commits to SVN.
>>
>> > I don't know of a a switch in 'git patch' to create a SVN like patch.
>>
>> Huh? This is news to me -- git diff --no-prefix generates patches which
>> are perfectly compatible with RB and SVN.
>>
>> > Thoughts?
>>
>> I would really like to understand what kind of problem you're experiencing.
>>
>> Thanks,
>> Roman.
>>
>
Re: reviewboard patches
Posted by "Angelo K. Huang" <an...@gmail.com>.
I tried that "git diff --no-prefix", not work for me either.
How to create patch out of 'git svn'? Do you have that similar experience?
--angelo
On Thu, Sep 15, 2011 at 7:49 PM, Roman Shaposhnik <rv...@apache.org> wrote:
> On Thu, Sep 15, 2011 at 7:20 PM, Alejandro Abdelnur <tu...@cloudera.com>
> wrote:
> > As many of you I'm GIT spoiled.
>
> Aren't we all ;-) In fact I highly advocate using git-svn to work with
> Apache svn repos -- all the niceties of Git plus direct commits to SVN.
>
> > I don't know of a a switch in 'git patch' to create a SVN like patch.
>
> Huh? This is news to me -- git diff --no-prefix generates patches which
> are perfectly compatible with RB and SVN.
>
> > Thoughts?
>
> I would really like to understand what kind of problem you're experiencing.
>
> Thanks,
> Roman.
>
Re: reviewboard patches
Posted by Roman Shaposhnik <rv...@apache.org>.
On Thu, Sep 15, 2011 at 7:20 PM, Alejandro Abdelnur <tu...@cloudera.com> wrote:
> As many of you I'm GIT spoiled.
Aren't we all ;-) In fact I highly advocate using git-svn to work with
Apache svn repos -- all the niceties of Git plus direct commits to SVN.
> I don't know of a a switch in 'git patch' to create a SVN like patch.
Huh? This is news to me -- git diff --no-prefix generates patches which
are perfectly compatible with RB and SVN.
> Thoughts?
I would really like to understand what kind of problem you're experiencing.
Thanks,
Roman.