You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2025/09/25 19:53:03 UTC

[I] Make `true`/`false` expression JSON serializable [iceberg-python]

Fokko opened a new issue, #2521:
URL: https://github.com/apache/iceberg-python/issues/2521

   ### Feature Request / Improvement
   
   Make sure that the `true`/`false` expression can be serialized to JSON:
   
   https://github.com/apache/iceberg-python/blob/e5e74534a4938fcace2c782a237474b7e94da68c/pyiceberg/expressions/__init__.py#L365-L394
   
   This is a special case, since it will not translate into an object, but to a string instead:
   
   ```json
   "true"
   ```
   
   ```json
   "false"
   ```
   
   This so-called root-model (since it doesn't convert to an object), needs to set the `root`: https://github.com/apache/iceberg-python/blob/e5e74534a4938fcace2c782a237474b7e94da68c/pyiceberg/transforms.py#L579-L588
   
   We use Pydantic for JSON serialization, which can be enabled by deriving from the `IcebergBaseModel`:
   
   https://github.com/apache/iceberg-python/blob/e5e74534a4938fcace2c782a237474b7e94da68c/pyiceberg/partitioning.py#L124
   
   Example tests can be found here:
   
   https://github.com/apache/iceberg-python/blob/e5e74534a4938fcace2c782a237474b7e94da68c/tests/table/test_partitioning.py#L116-L132


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] Make `true`/`false` expression JSON serializable [iceberg-python]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on issue #2521:
URL: https://github.com/apache/iceberg-python/issues/2521#issuecomment-3350401860

   @Kaviid Sure thing, maybe you can pick up where others left :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] Make `true`/`false` expression JSON serializable [iceberg-python]

Posted by "Kaviid (via GitHub)" <gi...@apache.org>.
Kaviid commented on issue #2521:
URL: https://github.com/apache/iceberg-python/issues/2521#issuecomment-3335796114

   Hello,
   I'm new here. Can I work on this issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] Make `true`/`false` expression JSON serializable [iceberg-python]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko closed issue #2521: Make `true`/`false` expression JSON serializable
URL: https://github.com/apache/iceberg-python/issues/2521


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org