You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/15 12:53:54 UTC
[GitHub] [bookkeeper] weiping-code opened a new pull request, #3334: [ISSUE 3295]Fix JVM exited when running localbookie with jdk17 (#3295)
weiping-code opened a new pull request, #3334:
URL: https://github.com/apache/bookkeeper/pull/3334
### Motivation
Currently, localbookie can't run with jdk17
### Changes
- remove flag AggressiveOpts
- add flag AutoBoxCacheMax=20000
- add flag BiasedLockingStartupDelay=500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #3334: [ISSUE 3295]Fix JVM exited when running localbookie with jdk17 (#3295)
Posted by GitBox <gi...@apache.org>.
eolivelli commented on PR #3334:
URL: https://github.com/apache/bookkeeper/pull/3334#issuecomment-1186866003
I am not very sure that we need to enforce:
add flag AutoBoxCacheMax=20000
add flag BiasedLockingStartupDelay=500
I would let the JDK use its own ergonomics
WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi merged pull request #3334: [ISSUE 3295]Fix JVM exited when running localbookie with jdk17 (#3295)
Posted by GitBox <gi...@apache.org>.
nicoloboschi merged PR #3334:
URL: https://github.com/apache/bookkeeper/pull/3334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] weiping-code commented on a diff in pull request #3334: [ISSUE 3295]Fix JVM exited when running localbookie with jdk17 (#3295)
Posted by GitBox <gi...@apache.org>.
weiping-code commented on code in PR #3334:
URL: https://github.com/apache/bookkeeper/pull/3334#discussion_r900182817
##########
bin/common.sh:
##########
@@ -96,7 +96,8 @@ else
-XX:MaxGCPauseMillis=10 \
-XX:+ParallelRefProcEnabled \
-XX:+UnlockExperimentalVMOptions \
- -XX:+AggressiveOpts \
+ -XX:AutoBoxCacheMax=20000 \
Review Comment:
This flag (-XX:+AggressiveOpts) was deprecated in JDK 11 and removed in JDK 12 (https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8199778), and according to link
The only effect that the flag currently has is setting AutoBoxCacheMax = 20000 and BiasedLockingStartupDelay = 500.
Both can be done manually by setting the corresponding flags on the command line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3334: [ISSUE 3295]Fix JVM exited when running localbookie with jdk17 (#3295)
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3334:
URL: https://github.com/apache/bookkeeper/pull/3334#issuecomment-1186910886
@weiping-code Thanks for your contribution, and welcome to bookkeeper community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3334: [ISSUE 3295]Fix JVM exited when running localbookie with jdk17 (#3295)
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3334:
URL: https://github.com/apache/bookkeeper/pull/3334#issuecomment-1186881502
@eolivelli We don't use Integer or locks a lot. So I think remove `AggressiveOpts` is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3334: [ISSUE 3295]Fix JVM exited when running localbookie with jdk17 (#3295)
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3334:
URL: https://github.com/apache/bookkeeper/pull/3334#issuecomment-1158345197
@weiping-code please rebase your code, we have deleted gradle build scripts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3334: [ISSUE 3295]Fix JVM exited when running localbookie with jdk17 (#3295)
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3334:
URL: https://github.com/apache/bookkeeper/pull/3334#issuecomment-1186812993
@eolivelli I have addressed the comments. PTAL again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] weiping-code closed pull request #3334: [ISSUE 3295]Fix JVM exited when running localbookie with jdk17 (#3295)
Posted by GitBox <gi...@apache.org>.
weiping-code closed pull request #3334: [ISSUE 3295]Fix JVM exited when running localbookie with jdk17 (#3295)
URL: https://github.com/apache/bookkeeper/pull/3334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3334: [ISSUE 3295]Fix JVM exited when running localbookie with jdk17 (#3295)
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3334:
URL: https://github.com/apache/bookkeeper/pull/3334#issuecomment-1157095612
@sudoHackIn @eolivelli PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on a diff in pull request #3334: [ISSUE 3295]Fix JVM exited when running localbookie with jdk17 (#3295)
Posted by GitBox <gi...@apache.org>.
eolivelli commented on code in PR #3334:
URL: https://github.com/apache/bookkeeper/pull/3334#discussion_r898812993
##########
bin/common.sh:
##########
@@ -96,7 +96,8 @@ else
-XX:MaxGCPauseMillis=10 \
-XX:+ParallelRefProcEnabled \
-XX:+UnlockExperimentalVMOptions \
- -XX:+AggressiveOpts \
+ -XX:AutoBoxCacheMax=20000 \
Review Comment:
I believe that we should drop this super specific values, and let the JVM auto tune.
there is nothing specific in BK that needs this stuff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #3334: [ISSUE 3295]Fix JVM exited when running localbookie with jdk17 (#3295)
Posted by GitBox <gi...@apache.org>.
eolivelli commented on PR #3334:
URL: https://github.com/apache/bookkeeper/pull/3334#issuecomment-1186864567
we should port this to 4.15 branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org