You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Johan Ström (JIRA)" <ji...@apache.org> on 2007/06/13 10:27:26 UTC

[jira] Created: (WW-1990) Scheme attribute for form tag

Scheme attribute for form tag
-----------------------------

                 Key: WW-1990
                 URL: https://issues.apache.org/struts/browse/WW-1990
             Project: Struts 2
          Issue Type: Improvement
          Components: Views
    Affects Versions: 2.0.8
            Reporter: Johan Ström


There is currently no way to set the scheme for a <s:form > tag (like you can with for example the s:url tag)

If a protected String scheme; is added and relevant setters (and tld changes) this can be used (components/Form.java):

269          String result = UrlHelper.buildUrl(actionMapper.getUriFromActionMapping(mapping), request, response, null, scheme, true, true);

This would do the same as the old code but make it respect the schema parameter.

Currently I have to subclass the form tag and override the evaluateExtraParamsServletRequest, copying all the code in it.. Also, since its a private function i have to subclass the populateComponentHtmlId (which is protected) in order to be able to call my own evaluateExtraParamsServletRequest at all.. Make it protected instead, or is there some reason to have it private?

Also, it would be nice to have the UrlHelper.buildUrl function "replaced" with something like this:

protected static String buildUrl(String action, HttpServletRequest request, HttpServletResponse response, Map params, String scheme, boolean includeContext, boolean encodeResult)
{
    return UrlHelper.buildUrl(action, request, response, params, scheme, true, true);
}

and then, in evaluateExtraParamsServletRequest (and i guess the portlet variant too), call this local buildUrl instead. This would allow me to override (or extend) the URL building easier. I would want this to implement "restifying" my URLs (ie inject "restfull" parameters for useage with the Restful2ActionMapper).


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-1990) Add scheme attribute to the form tag

Posted by "Matt Raible (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41917 ] 

Matt Raible commented on WW-1990:
---------------------------------

I think it makes sense to add <s:form secure="true"> to get a full https:// URL. In addition, I'd like to see a "secure" attribute added to struts.xml so you can secure an entire package/namespace.

It'd also be cool to have secure="false" on a package to get automatic switching back to http.

> Add scheme attribute to the form tag
> ------------------------------------
>
>                 Key: WW-1990
>                 URL: https://issues.apache.org/struts/browse/WW-1990
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.8, 2.0.9
>            Reporter: Johan Ström
>            Assignee: James Holmes
>             Fix For: 2.0.10
>
>
> There is currently no way to set the scheme for a <s:form > tag (like you can with for example the s:url tag)
> If a protected String scheme; is added and relevant setters (and tld changes) this can be used (components/Form.java):
> 269          String result = UrlHelper.buildUrl(actionMapper.getUriFromActionMapping(mapping), request, response, null, scheme, true, true);
> This would do the same as the old code but make it respect the schema parameter.
> Currently I have to subclass the form tag and override the evaluateExtraParamsServletRequest, copying all the code in it.. Also, since its a private function i have to subclass the populateComponentHtmlId (which is protected) in order to be able to call my own evaluateExtraParamsServletRequest at all.. Make it protected instead, or is there some reason to have it private?
> Also, it would be nice to have the UrlHelper.buildUrl function "replaced" with something like this:
> protected static String buildUrl(String action, HttpServletRequest request, HttpServletResponse response, Map params, String scheme, boolean includeContext, boolean encodeResult)
> {
>     return UrlHelper.buildUrl(action, request, response, params, scheme, true, true);
> }
> and then, in evaluateExtraParamsServletRequest (and i guess the portlet variant too), call this local buildUrl instead. This would allow me to override (or extend) the URL building easier. I would want this to implement "restifying" my URLs (ie inject "restfull" parameters for useage with the Restful2ActionMapper).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WW-1990) Add scheme attribute to the form tag

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Holmes reassigned WW-1990:
--------------------------------

    Assignee:     (was: James Holmes)

> Add scheme attribute to the form tag
> ------------------------------------
>
>                 Key: WW-1990
>                 URL: https://issues.apache.org/struts/browse/WW-1990
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.8, 2.0.9
>            Reporter: Johan Ström
>             Fix For: 2.1.0
>
>
> There is currently no way to set the scheme for a <s:form > tag (like you can with for example the s:url tag)
> If a protected String scheme; is added and relevant setters (and tld changes) this can be used (components/Form.java):
> 269          String result = UrlHelper.buildUrl(actionMapper.getUriFromActionMapping(mapping), request, response, null, scheme, true, true);
> This would do the same as the old code but make it respect the schema parameter.
> Currently I have to subclass the form tag and override the evaluateExtraParamsServletRequest, copying all the code in it.. Also, since its a private function i have to subclass the populateComponentHtmlId (which is protected) in order to be able to call my own evaluateExtraParamsServletRequest at all.. Make it protected instead, or is there some reason to have it private?
> Also, it would be nice to have the UrlHelper.buildUrl function "replaced" with something like this:
> protected static String buildUrl(String action, HttpServletRequest request, HttpServletResponse response, Map params, String scheme, boolean includeContext, boolean encodeResult)
> {
>     return UrlHelper.buildUrl(action, request, response, params, scheme, true, true);
> }
> and then, in evaluateExtraParamsServletRequest (and i guess the portlet variant too), call this local buildUrl instead. This would allow me to override (or extend) the URL building easier. I would want this to implement "restifying" my URLs (ie inject "restfull" parameters for useage with the Restful2ActionMapper).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-1990) Scheme attribute for form tag

Posted by "Nils-Helge Garli (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41784 ] 

Nils-Helge Garli commented on WW-1990:
--------------------------------------

What kind of urls do you need to set the schema for? URLs to external servlets? Within a portlet, I'm not sure if this is needed.

> Scheme attribute for form tag
> -----------------------------
>
>                 Key: WW-1990
>                 URL: https://issues.apache.org/struts/browse/WW-1990
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.8
>            Reporter: Johan Ström
>             Fix For: Future
>
>
> There is currently no way to set the scheme for a <s:form > tag (like you can with for example the s:url tag)
> If a protected String scheme; is added and relevant setters (and tld changes) this can be used (components/Form.java):
> 269          String result = UrlHelper.buildUrl(actionMapper.getUriFromActionMapping(mapping), request, response, null, scheme, true, true);
> This would do the same as the old code but make it respect the schema parameter.
> Currently I have to subclass the form tag and override the evaluateExtraParamsServletRequest, copying all the code in it.. Also, since its a private function i have to subclass the populateComponentHtmlId (which is protected) in order to be able to call my own evaluateExtraParamsServletRequest at all.. Make it protected instead, or is there some reason to have it private?
> Also, it would be nice to have the UrlHelper.buildUrl function "replaced" with something like this:
> protected static String buildUrl(String action, HttpServletRequest request, HttpServletResponse response, Map params, String scheme, boolean includeContext, boolean encodeResult)
> {
>     return UrlHelper.buildUrl(action, request, response, params, scheme, true, true);
> }
> and then, in evaluateExtraParamsServletRequest (and i guess the portlet variant too), call this local buildUrl instead. This would allow me to override (or extend) the URL building easier. I would want this to implement "restifying" my URLs (ie inject "restfull" parameters for useage with the Restful2ActionMapper).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WW-1990) Scheme attribute for form tag

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Holmes reassigned WW-1990:
--------------------------------

    Assignee: James Holmes

> Scheme attribute for form tag
> -----------------------------
>
>                 Key: WW-1990
>                 URL: https://issues.apache.org/struts/browse/WW-1990
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.8
>            Reporter: Johan Ström
>            Assignee: James Holmes
>             Fix For: 2.0.10
>
>
> There is currently no way to set the scheme for a <s:form > tag (like you can with for example the s:url tag)
> If a protected String scheme; is added and relevant setters (and tld changes) this can be used (components/Form.java):
> 269          String result = UrlHelper.buildUrl(actionMapper.getUriFromActionMapping(mapping), request, response, null, scheme, true, true);
> This would do the same as the old code but make it respect the schema parameter.
> Currently I have to subclass the form tag and override the evaluateExtraParamsServletRequest, copying all the code in it.. Also, since its a private function i have to subclass the populateComponentHtmlId (which is protected) in order to be able to call my own evaluateExtraParamsServletRequest at all.. Make it protected instead, or is there some reason to have it private?
> Also, it would be nice to have the UrlHelper.buildUrl function "replaced" with something like this:
> protected static String buildUrl(String action, HttpServletRequest request, HttpServletResponse response, Map params, String scheme, boolean includeContext, boolean encodeResult)
> {
>     return UrlHelper.buildUrl(action, request, response, params, scheme, true, true);
> }
> and then, in evaluateExtraParamsServletRequest (and i guess the portlet variant too), call this local buildUrl instead. This would allow me to override (or extend) the URL building easier. I would want this to implement "restifying" my URLs (ie inject "restfull" parameters for useage with the Restful2ActionMapper).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-1990) Add scheme attribute to the form tag

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Holmes updated WW-1990:
-----------------------------

    Fix Version/s:     (was: 2.0.10)
                   2.0.11

> Add scheme attribute to the form tag
> ------------------------------------
>
>                 Key: WW-1990
>                 URL: https://issues.apache.org/struts/browse/WW-1990
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.8, 2.0.9
>            Reporter: Johan Ström
>            Assignee: James Holmes
>             Fix For: 2.0.11
>
>
> There is currently no way to set the scheme for a <s:form > tag (like you can with for example the s:url tag)
> If a protected String scheme; is added and relevant setters (and tld changes) this can be used (components/Form.java):
> 269          String result = UrlHelper.buildUrl(actionMapper.getUriFromActionMapping(mapping), request, response, null, scheme, true, true);
> This would do the same as the old code but make it respect the schema parameter.
> Currently I have to subclass the form tag and override the evaluateExtraParamsServletRequest, copying all the code in it.. Also, since its a private function i have to subclass the populateComponentHtmlId (which is protected) in order to be able to call my own evaluateExtraParamsServletRequest at all.. Make it protected instead, or is there some reason to have it private?
> Also, it would be nice to have the UrlHelper.buildUrl function "replaced" with something like this:
> protected static String buildUrl(String action, HttpServletRequest request, HttpServletResponse response, Map params, String scheme, boolean includeContext, boolean encodeResult)
> {
>     return UrlHelper.buildUrl(action, request, response, params, scheme, true, true);
> }
> and then, in evaluateExtraParamsServletRequest (and i guess the portlet variant too), call this local buildUrl instead. This would allow me to override (or extend) the URL building easier. I would want this to implement "restifying" my URLs (ie inject "restfull" parameters for useage with the Restful2ActionMapper).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-1990) Add scheme attribute to the form tag

Posted by "Don Brown (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Don Brown updated WW-1990:
--------------------------

    Fix Version/s:     (was: 2.0.11)
                   2.1.0

> Add scheme attribute to the form tag
> ------------------------------------
>
>                 Key: WW-1990
>                 URL: https://issues.apache.org/struts/browse/WW-1990
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.8, 2.0.9
>            Reporter: Johan Ström
>            Assignee: James Holmes
>             Fix For: 2.1.0
>
>
> There is currently no way to set the scheme for a <s:form > tag (like you can with for example the s:url tag)
> If a protected String scheme; is added and relevant setters (and tld changes) this can be used (components/Form.java):
> 269          String result = UrlHelper.buildUrl(actionMapper.getUriFromActionMapping(mapping), request, response, null, scheme, true, true);
> This would do the same as the old code but make it respect the schema parameter.
> Currently I have to subclass the form tag and override the evaluateExtraParamsServletRequest, copying all the code in it.. Also, since its a private function i have to subclass the populateComponentHtmlId (which is protected) in order to be able to call my own evaluateExtraParamsServletRequest at all.. Make it protected instead, or is there some reason to have it private?
> Also, it would be nice to have the UrlHelper.buildUrl function "replaced" with something like this:
> protected static String buildUrl(String action, HttpServletRequest request, HttpServletResponse response, Map params, String scheme, boolean includeContext, boolean encodeResult)
> {
>     return UrlHelper.buildUrl(action, request, response, params, scheme, true, true);
> }
> and then, in evaluateExtraParamsServletRequest (and i guess the portlet variant too), call this local buildUrl instead. This would allow me to override (or extend) the URL building easier. I would want this to implement "restifying" my URLs (ie inject "restfull" parameters for useage with the Restful2ActionMapper).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-1990) Add scheme attribute to the form tag

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41918 ] 

James Holmes commented on WW-1990:
----------------------------------

So the question becomes, do we add a "secure" attribute or a "scheme" attribute. I can see how adding a "secure" attribute plays into a grander plan of being able to do this on a package level. SSLEXT provides this sort of functionality for Struts 1 and can be referenced for ideas.

http://sslext.sourceforge.net/

> Add scheme attribute to the form tag
> ------------------------------------
>
>                 Key: WW-1990
>                 URL: https://issues.apache.org/struts/browse/WW-1990
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.8, 2.0.9
>            Reporter: Johan Ström
>            Assignee: James Holmes
>             Fix For: 2.0.10
>
>
> There is currently no way to set the scheme for a <s:form > tag (like you can with for example the s:url tag)
> If a protected String scheme; is added and relevant setters (and tld changes) this can be used (components/Form.java):
> 269          String result = UrlHelper.buildUrl(actionMapper.getUriFromActionMapping(mapping), request, response, null, scheme, true, true);
> This would do the same as the old code but make it respect the schema parameter.
> Currently I have to subclass the form tag and override the evaluateExtraParamsServletRequest, copying all the code in it.. Also, since its a private function i have to subclass the populateComponentHtmlId (which is protected) in order to be able to call my own evaluateExtraParamsServletRequest at all.. Make it protected instead, or is there some reason to have it private?
> Also, it would be nice to have the UrlHelper.buildUrl function "replaced" with something like this:
> protected static String buildUrl(String action, HttpServletRequest request, HttpServletResponse response, Map params, String scheme, boolean includeContext, boolean encodeResult)
> {
>     return UrlHelper.buildUrl(action, request, response, params, scheme, true, true);
> }
> and then, in evaluateExtraParamsServletRequest (and i guess the portlet variant too), call this local buildUrl instead. This would allow me to override (or extend) the URL building easier. I would want this to implement "restifying" my URLs (ie inject "restfull" parameters for useage with the Restful2ActionMapper).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-1990) Add scheme attribute to the form tag

Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Husted updated WW-1990:
---------------------------

    Fix Version/s:     (was: 2.1.1)
                   Future

More discussion seems warranted. 


> Add scheme attribute to the form tag
> ------------------------------------
>
>                 Key: WW-1990
>                 URL: https://issues.apache.org/struts/browse/WW-1990
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Tags
>    Affects Versions: 2.0.8, 2.0.9
>            Reporter: Johan Ström
>             Fix For: Future
>
>
> There is currently no way to set the scheme for a <s:form > tag (like you can with for example the s:url tag)
> If a protected String scheme; is added and relevant setters (and tld changes) this can be used (components/Form.java):
> 269          String result = UrlHelper.buildUrl(actionMapper.getUriFromActionMapping(mapping), request, response, null, scheme, true, true);
> This would do the same as the old code but make it respect the schema parameter.
> Currently I have to subclass the form tag and override the evaluateExtraParamsServletRequest, copying all the code in it.. Also, since its a private function i have to subclass the populateComponentHtmlId (which is protected) in order to be able to call my own evaluateExtraParamsServletRequest at all.. Make it protected instead, or is there some reason to have it private?
> Also, it would be nice to have the UrlHelper.buildUrl function "replaced" with something like this:
> protected static String buildUrl(String action, HttpServletRequest request, HttpServletResponse response, Map params, String scheme, boolean includeContext, boolean encodeResult)
> {
>     return UrlHelper.buildUrl(action, request, response, params, scheme, true, true);
> }
> and then, in evaluateExtraParamsServletRequest (and i guess the portlet variant too), call this local buildUrl instead. This would allow me to override (or extend) the URL building easier. I would want this to implement "restifying" my URLs (ie inject "restfull" parameters for useage with the Restful2ActionMapper).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-1990) Scheme attribute for form tag

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Holmes updated WW-1990:
-----------------------------

    Affects Version/s: 2.0.9
        Fix Version/s:     (was: Future)
                       2.0.10

> Scheme attribute for form tag
> -----------------------------
>
>                 Key: WW-1990
>                 URL: https://issues.apache.org/struts/browse/WW-1990
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.8, 2.0.9
>            Reporter: Johan Ström
>            Assignee: James Holmes
>             Fix For: 2.0.10
>
>
> There is currently no way to set the scheme for a <s:form > tag (like you can with for example the s:url tag)
> If a protected String scheme; is added and relevant setters (and tld changes) this can be used (components/Form.java):
> 269          String result = UrlHelper.buildUrl(actionMapper.getUriFromActionMapping(mapping), request, response, null, scheme, true, true);
> This would do the same as the old code but make it respect the schema parameter.
> Currently I have to subclass the form tag and override the evaluateExtraParamsServletRequest, copying all the code in it.. Also, since its a private function i have to subclass the populateComponentHtmlId (which is protected) in order to be able to call my own evaluateExtraParamsServletRequest at all.. Make it protected instead, or is there some reason to have it private?
> Also, it would be nice to have the UrlHelper.buildUrl function "replaced" with something like this:
> protected static String buildUrl(String action, HttpServletRequest request, HttpServletResponse response, Map params, String scheme, boolean includeContext, boolean encodeResult)
> {
>     return UrlHelper.buildUrl(action, request, response, params, scheme, true, true);
> }
> and then, in evaluateExtraParamsServletRequest (and i guess the portlet variant too), call this local buildUrl instead. This would allow me to override (or extend) the URL building easier. I would want this to implement "restifying" my URLs (ie inject "restfull" parameters for useage with the Restful2ActionMapper).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-1990) Scheme attribute for form tag

Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Husted updated WW-1990:
---------------------------

    Fix Version/s: Future

Setting Fix Version to "future" for issues without a set fix version. 


> Scheme attribute for form tag
> -----------------------------
>
>                 Key: WW-1990
>                 URL: https://issues.apache.org/struts/browse/WW-1990
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.8
>            Reporter: Johan Ström
>             Fix For: Future
>
>
> There is currently no way to set the scheme for a <s:form > tag (like you can with for example the s:url tag)
> If a protected String scheme; is added and relevant setters (and tld changes) this can be used (components/Form.java):
> 269          String result = UrlHelper.buildUrl(actionMapper.getUriFromActionMapping(mapping), request, response, null, scheme, true, true);
> This would do the same as the old code but make it respect the schema parameter.
> Currently I have to subclass the form tag and override the evaluateExtraParamsServletRequest, copying all the code in it.. Also, since its a private function i have to subclass the populateComponentHtmlId (which is protected) in order to be able to call my own evaluateExtraParamsServletRequest at all.. Make it protected instead, or is there some reason to have it private?
> Also, it would be nice to have the UrlHelper.buildUrl function "replaced" with something like this:
> protected static String buildUrl(String action, HttpServletRequest request, HttpServletResponse response, Map params, String scheme, boolean includeContext, boolean encodeResult)
> {
>     return UrlHelper.buildUrl(action, request, response, params, scheme, true, true);
> }
> and then, in evaluateExtraParamsServletRequest (and i guess the portlet variant too), call this local buildUrl instead. This would allow me to override (or extend) the URL building easier. I would want this to implement "restifying" my URLs (ie inject "restfull" parameters for useage with the Restful2ActionMapper).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-1990) Add scheme attribute to the form tag

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Holmes updated WW-1990:
-----------------------------

    Summary: Add scheme attribute to the form tag  (was: Scheme attribute for form tag)

> Add scheme attribute to the form tag
> ------------------------------------
>
>                 Key: WW-1990
>                 URL: https://issues.apache.org/struts/browse/WW-1990
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.8, 2.0.9
>            Reporter: Johan Ström
>            Assignee: James Holmes
>             Fix For: 2.0.10
>
>
> There is currently no way to set the scheme for a <s:form > tag (like you can with for example the s:url tag)
> If a protected String scheme; is added and relevant setters (and tld changes) this can be used (components/Form.java):
> 269          String result = UrlHelper.buildUrl(actionMapper.getUriFromActionMapping(mapping), request, response, null, scheme, true, true);
> This would do the same as the old code but make it respect the schema parameter.
> Currently I have to subclass the form tag and override the evaluateExtraParamsServletRequest, copying all the code in it.. Also, since its a private function i have to subclass the populateComponentHtmlId (which is protected) in order to be able to call my own evaluateExtraParamsServletRequest at all.. Make it protected instead, or is there some reason to have it private?
> Also, it would be nice to have the UrlHelper.buildUrl function "replaced" with something like this:
> protected static String buildUrl(String action, HttpServletRequest request, HttpServletResponse response, Map params, String scheme, boolean includeContext, boolean encodeResult)
> {
>     return UrlHelper.buildUrl(action, request, response, params, scheme, true, true);
> }
> and then, in evaluateExtraParamsServletRequest (and i guess the portlet variant too), call this local buildUrl instead. This would allow me to override (or extend) the URL building easier. I would want this to implement "restifying" my URLs (ie inject "restfull" parameters for useage with the Restful2ActionMapper).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.