You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Yingyi Bu (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/01/19 02:35:08 UTC
Change in asterixdb[master]: ASTERIXDB-1258, ASTERIXDB-1259: fix test queries.
Yingyi Bu has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/588
Change subject: ASTERIXDB-1258, ASTERIXDB-1259: fix test queries.
......................................................................
ASTERIXDB-1258, ASTERIXDB-1259: fix test queries.
Change-Id: I6b3a7d26a1931e4ec146e243f2b89d2586996b75
---
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv16/cross-dv16.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-issue455/query-issue455.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-issue489/query-issue489.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
4 files changed, 10 insertions(+), 8 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/88/588/1
diff --git a/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv16/cross-dv16.1.ddl.sqlpp b/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv16/cross-dv16.1.ddl.sqlpp
index e3c10cc..5596974 100644
--- a/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv16/cross-dv16.1.ddl.sqlpp
+++ b/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv16/cross-dv16.1.ddl.sqlpp
@@ -39,4 +39,8 @@
// UDF with two inputs
create function testdv1.fun03(){
testdv1.fun04()
-}
\ No newline at end of file
+}
+
+create function testdv1.fun04(){
+testdv1.fun02()
+}
diff --git a/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-issue455/query-issue455.1.ddl.sqlpp b/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-issue455/query-issue455.1.ddl.sqlpp
index 6cbb47f..1980f01 100644
--- a/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-issue455/query-issue455.1.ddl.sqlpp
+++ b/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-issue455/query-issue455.1.ddl.sqlpp
@@ -30,5 +30,5 @@
create function printName()
{
-"AsterixDB Shared nothing parallel BDMS"
+'AsterixDB Shared nothing parallel BDMS'
}
diff --git a/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-issue489/query-issue489.1.ddl.sqlpp b/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-issue489/query-issue489.1.ddl.sqlpp
index 504f3ac..094401f 100644
--- a/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-issue489/query-issue489.1.ddl.sqlpp
+++ b/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-issue489/query-issue489.1.ddl.sqlpp
@@ -29,10 +29,10 @@
create function f1()
{
-"function with no input"
+'function with no input'
}
create function f1(a)
{
-"function with input"
+'function with input'
}
\ No newline at end of file
diff --git a/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml b/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
index 4852f8f..58d9323 100644
--- a/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
+++ b/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
@@ -5447,13 +5447,12 @@
<output-dir compare="Text">cross-dv15</output-dir>
</compilation-unit>
</test-case>
- <!--ASTERIXDB-1258
<test-case FilePath="cross-dataverse">
<compilation-unit name="cross-dv16">
<output-dir compare="Text">cross-dv16</output-dir>
<expected-error>SyntaxError: ERROR:Recursive invocation testdv1.fun04@0</expected-error>
</compilation-unit>
- </test-case> -->
+ </test-case>
<!--NotImplementedException: No binary comparator factory implemented for type RECORD.
<test-case FilePath="cross-dataverse">
<compilation-unit name="cross-dv17">
@@ -5510,13 +5509,12 @@
<output-dir compare="Text">query-issue172</output-dir>
</compilation-unit>
</test-case>
- <!-- ASTERIXDB-1259
<test-case FilePath="user-defined-functions">
<compilation-unit name="query-issue455">
<output-dir compare="Text">query-issue455</output-dir>
<expected-error>SyntaxError: function test.printName@0 is undefined</expected-error>
</compilation-unit>
- </test-case>-->
+ </test-case>
<test-case FilePath="user-defined-functions">
<compilation-unit name="query-issue489">
<output-dir compare="Text">query-issue489</output-dir>
--
To view, visit https://asterix-gerrit.ics.uci.edu/588
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b3a7d26a1931e4ec146e243f2b89d2586996b75
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Change in asterixdb[master]: ASTERIXDB-1258, ASTERIXDB-1259: fix test queries.
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1258, ASTERIXDB-1259: fix test queries.
......................................................................
Patch Set 1: Verified-1
Build Unstable
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/720/ : UNSTABLE
--
To view, visit https://asterix-gerrit.ics.uci.edu/588
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3a7d26a1931e4ec146e243f2b89d2586996b75
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1258, ASTERIXDB-1259: fix test queries.
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1258, ASTERIXDB-1259: fix test queries.
......................................................................
Patch Set 1: Verified+1
Build Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/721/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/588
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3a7d26a1931e4ec146e243f2b89d2586996b75
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1258, ASTERIXDB-1259: fix test queries.
Posted by "Yingyi Bu (Code Review)" <do...@asterixdb.incubator.apache.org>.
Yingyi Bu has submitted this change and it was merged.
Change subject: ASTERIXDB-1258, ASTERIXDB-1259: fix test queries.
......................................................................
ASTERIXDB-1258, ASTERIXDB-1259: fix test queries.
Change-Id: I6b3a7d26a1931e4ec146e243f2b89d2586996b75
Reviewed-on: https://asterix-gerrit.ics.uci.edu/588
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Murtadha Hubail <hu...@gmail.com>
---
M asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv16/cross-dv16.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-issue455/query-issue455.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-issue489/query-issue489.1.ddl.sqlpp
M asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
4 files changed, 10 insertions(+), 8 deletions(-)
Approvals:
Murtadha Hubail: Looks good to me, approved
Jenkins: Verified
diff --git a/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv16/cross-dv16.1.ddl.sqlpp b/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv16/cross-dv16.1.ddl.sqlpp
index e3c10cc..5596974 100644
--- a/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv16/cross-dv16.1.ddl.sqlpp
+++ b/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv16/cross-dv16.1.ddl.sqlpp
@@ -39,4 +39,8 @@
// UDF with two inputs
create function testdv1.fun03(){
testdv1.fun04()
-}
\ No newline at end of file
+}
+
+create function testdv1.fun04(){
+testdv1.fun02()
+}
diff --git a/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-issue455/query-issue455.1.ddl.sqlpp b/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-issue455/query-issue455.1.ddl.sqlpp
index 6cbb47f..1980f01 100644
--- a/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-issue455/query-issue455.1.ddl.sqlpp
+++ b/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-issue455/query-issue455.1.ddl.sqlpp
@@ -30,5 +30,5 @@
create function printName()
{
-"AsterixDB Shared nothing parallel BDMS"
+'AsterixDB Shared nothing parallel BDMS'
}
diff --git a/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-issue489/query-issue489.1.ddl.sqlpp b/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-issue489/query-issue489.1.ddl.sqlpp
index 504f3ac..094401f 100644
--- a/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-issue489/query-issue489.1.ddl.sqlpp
+++ b/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/query-issue489/query-issue489.1.ddl.sqlpp
@@ -29,10 +29,10 @@
create function f1()
{
-"function with no input"
+'function with no input'
}
create function f1(a)
{
-"function with input"
+'function with input'
}
\ No newline at end of file
diff --git a/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml b/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
index 4852f8f..58d9323 100644
--- a/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
+++ b/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
@@ -5447,13 +5447,12 @@
<output-dir compare="Text">cross-dv15</output-dir>
</compilation-unit>
</test-case>
- <!--ASTERIXDB-1258
<test-case FilePath="cross-dataverse">
<compilation-unit name="cross-dv16">
<output-dir compare="Text">cross-dv16</output-dir>
<expected-error>SyntaxError: ERROR:Recursive invocation testdv1.fun04@0</expected-error>
</compilation-unit>
- </test-case> -->
+ </test-case>
<!--NotImplementedException: No binary comparator factory implemented for type RECORD.
<test-case FilePath="cross-dataverse">
<compilation-unit name="cross-dv17">
@@ -5510,13 +5509,12 @@
<output-dir compare="Text">query-issue172</output-dir>
</compilation-unit>
</test-case>
- <!-- ASTERIXDB-1259
<test-case FilePath="user-defined-functions">
<compilation-unit name="query-issue455">
<output-dir compare="Text">query-issue455</output-dir>
<expected-error>SyntaxError: function test.printName@0 is undefined</expected-error>
</compilation-unit>
- </test-case>-->
+ </test-case>
<test-case FilePath="user-defined-functions">
<compilation-unit name="query-issue489">
<output-dir compare="Text">query-issue489</output-dir>
--
To view, visit https://asterix-gerrit.ics.uci.edu/588
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b3a7d26a1931e4ec146e243f2b89d2586996b75
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Change in asterixdb[master]: ASTERIXDB-1258, ASTERIXDB-1259: fix test queries.
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1258, ASTERIXDB-1259: fix test queries.
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/720/
--
To view, visit https://asterix-gerrit.ics.uci.edu/588
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3a7d26a1931e4ec146e243f2b89d2586996b75
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1258, ASTERIXDB-1259: fix test queries.
Posted by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org>.
Murtadha Hubail has posted comments on this change.
Change subject: ASTERIXDB-1258, ASTERIXDB-1259: fix test queries.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/588
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3a7d26a1931e4ec146e243f2b89d2586996b75
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1258, ASTERIXDB-1259: fix test queries.
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1258, ASTERIXDB-1259: fix test queries.
......................................................................
Patch Set 1: -Verified
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/721/
--
To view, visit https://asterix-gerrit.ics.uci.edu/588
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3a7d26a1931e4ec146e243f2b89d2586996b75
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No