[GitHub] [geode] rhoughton-pivot opened pull request #3058: GEODE-6259: Refine version specification and consumption

["rhoughton-pivot (GitHub)" <gi...@apache.org>]

* Do not delay publication logic evaluation to accommodate a plugin we no longer use.
* Streamline version specification -- set version directly rather than through three separate properties.
* Remove scripted references to removed versionNumber property.
* Streamline publication target logic -- specify mavenRepository directly rather than via an interpolated mavenSnapshotBucket
* Concourse environment variable MAVEN_SNAPSNOT_BUCKET is now a complete bucket path.
* Concourse uses a semver object as the source-of-truth for binary
  build-id and version.  Zero-pad build-id for lexicographical sorting of artifacts.
* Use semver content to help determine release or snapshot in concourse
* Concourse uses 'SNAPSHOT' as the semver pre-release token for develop (from "build")

-----

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3058 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on pull request #3058: GEODE-6259: Refine version specification and consumption

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

I would consider having the Gradle script do the padding if we don't need the padded value in these bash scripts. 

[ Full content available at: https://github.com/apache/geode/pull/3058 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on pull request #3058: GEODE-6259: Refine version specification and consumption

["PurelyApplied (GitHub)" <gi...@apache.org>]

If you put a `println credentials` before and after the `credentials` declaration, both report `[username: null]`, so it appears that the default credential set is a singleton with a null `username`.  I'm not sure if this was different in Gradle4, though -- I would also be unsurprised by an emptyset of credentials or a singleton with a `null` rather than a credential object with a `null` username and password.

[ Full content available at: https://github.com/apache/geode/pull/3058 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #3058: GEODE-6259: Refine version specification and consumption

["PurelyApplied (GitHub)" <gi...@apache.org>]

It warrants discussion on what we wish to consider the actual source of truth for versioning, and how that should relate to the pipeline's "operational truth."  As a Geode developer, it is ideal for me to know the build ID on a given job, but as a Geode consumer, we seem to want to only expose the newest `-SNAPSHOT` without the build ID.  So on the one hand, the fully-qualified semver as passed to the Concourse job is my truth as a developer, but as a consumer, only the `1.9.0-SNAPSHOT` et al as present in our `gradle.properties` matters.

I would personally prefer to publish the snapshot with the build ID, but we have added the logic to only publish a `-SNAPSHOT` to the gradle.  That could be refined in whatever direction discussion suggests.

[ Full content available at: https://github.com/apache/geode/pull/3058 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied closed pull request #3058: GEODE-6259: Refine version specification and consumption

["PurelyApplied (GitHub)" <gi...@apache.org>]

[ pull request closed by PurelyApplied ]

[ Full content available at: https://github.com/apache/geode/pull/3058 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on pull request #3058: GEODE-6259: Refine version specification and consumption

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

You may still need this if statement to avoid GCS handler trying to use credentials. I feel like this was an issue.

[ Full content available at: https://github.com/apache/geode/pull/3058 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org