[GitHub] arogozhnikov opened a new pull request #12678: Fix https://github.com/apache/incubator-mxnet/issues/12672

[GitBox <gi...@apache.org>]

arogozhnikov opened a new pull request #12678: Fix https://github.com/apache/incubator-mxnet/issues/12672
URL: https://github.com/apache/incubator-mxnet/pull/12678
 
 
   ## Description ##
   
   Problem that caused #12672 is in using np.ascontiguousarray,
   which is buggy for zero-dimensional arrays
   (see https://github.com/numpy/numpy/issues/5300 for details and discussion).
   
   Here I use the solution proposed by numpy team:
   switch to `np.asarray` with `order='C'`.
   
   
   ### Essentials ###
   
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   
   - use `np.asarray` instead of `np.ascontiguousarray`, tests added for indexing and for init.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services