You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/02/04 16:03:00 UTC

[jira] [Commented] (SOLR-14239) Fix the behavior of CaffeineCache.computeIfAbsent on branch_8x

    [ https://issues.apache.org/jira/browse/SOLR-14239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029952#comment-17029952 ] 

ASF subversion and git services commented on SOLR-14239:
--------------------------------------------------------

Commit 4a002411fcb40a9ac04e59c072e27ac41425119d in lucene-solr's branch refs/heads/branch_8x from Andrzej Bialecki
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=4a00241 ]

SOLR-14239: Fix the behavior of CaffeineCache.computeIfAbsent on branch_8x.


> Fix the behavior of CaffeineCache.computeIfAbsent on branch_8x
> --------------------------------------------------------------
>
>                 Key: SOLR-14239
>                 URL: https://issues.apache.org/jira/browse/SOLR-14239
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 8.4.1
>            Reporter: Andrzej Bialecki
>            Assignee: Andrzej Bialecki
>            Priority: Major
>             Fix For: 8.5
>
>
> Spin-off from SOLR-13817, spotted by Andy Webb.
> The back-port of {{CaffeineCache}} to branch_8x is missing a conditional statement in {{computeIfAbsent}} which breaks the contract of this method, i.e. if the loading function returns null the cache mapping should remain unchanged and a null value should be returned.
> Note: this only affects branch_8x, master already has this conditional.
> This issue also modifies comments in the default {{solrconfig.xml}} to indicate that the old cache implementations existing in branch_8x are deprecated in favor of CaffeineCache.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org