You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/28 20:17:52 UTC

[GitHub] [superset] shawnzhu commented on a change in pull request #14897: fix: docker superset home and datadir

shawnzhu commented on a change in pull request #14897:
URL: https://github.com/apache/superset/pull/14897#discussion_r641795859



##########
File path: Dockerfile
##########
@@ -85,6 +85,7 @@ ENV LANG=C.UTF-8 \
     SUPERSET_PORT=8088
 
 RUN useradd --user-group -d ${SUPERSET_HOME} --no-log-init --shell /bin/bash superset \
+        && mkdir -p ${SUPERSET_HOME} \

Review comment:
       :point_up: is caused by missing directory `/app`, which comes after this line but really should put before it:
   
   https://github.com/apache/superset/blob/0eb34be78937edc509b6df872bc831d28add675f/Dockerfile#L88
   
   see my PR: #14903 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org