You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2008/09/24 01:21:46 UTC
[jira] Created: (HADOOP-4254) Cannot setSpaceQuota to 1TB
Cannot setSpaceQuota to 1TB
---------------------------
Key: HADOOP-4254
URL: https://issues.apache.org/jira/browse/HADOOP-4254
Project: Hadoop Core
Issue Type: Bug
Components: dfs
Reporter: Tsz Wo (Nicholas), SZE
When setting space quota to 1TB, it shows "/ by zero".
{noformat}
bash-3.2$ ./bin/hadoop dfsadmin -setSpaceQuota 1TB /user
setSpaceQuota: / by zero
{noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4254) Cannot setSpaceQuota to 1TB
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-4254:
---------------------------------
Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)
> Cannot setSpaceQuota to 1TB
> ---------------------------
>
> Key: HADOOP-4254
> URL: https://issues.apache.org/jira/browse/HADOOP-4254
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Raghu Angadi
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4254.patch, HADOOP-4254.patch
>
>
> When setting space quota to 1TB, it shows "/ by zero".
> {noformat}
> bash-3.2$ ./bin/hadoop dfsadmin -setSpaceQuota 1TB /user
> setSpaceQuota: / by zero
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4254) Cannot setSpaceQuota to 1TB
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633968#action_12633968 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-4254:
------------------------------------------------
The problem is due to the constructor of SetQuotaCommand. There is a int overflow for setting multiplier = 1024 * 1024 * 1024 * 1024, where the type of multiplier is long. A simple fix is to change 1024 to 1024L. I suggest we use StringUtils.TraditionalBinaryPrefix to parsing the value.
> Cannot setSpaceQuota to 1TB
> ---------------------------
>
> Key: HADOOP-4254
> URL: https://issues.apache.org/jira/browse/HADOOP-4254
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
>
> When setting space quota to 1TB, it shows "/ by zero".
> {noformat}
> bash-3.2$ ./bin/hadoop dfsadmin -setSpaceQuota 1TB /user
> setSpaceQuota: / by zero
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4254) Cannot setSpaceQuota to 1TB
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634709#action_12634709 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-4254:
------------------------------------------------
+1 patch looks good.
> Cannot setSpaceQuota to 1TB
> ---------------------------
>
> Key: HADOOP-4254
> URL: https://issues.apache.org/jira/browse/HADOOP-4254
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Raghu Angadi
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4254.patch, HADOOP-4254.patch
>
>
> When setting space quota to 1TB, it shows "/ by zero".
> {noformat}
> bash-3.2$ ./bin/hadoop dfsadmin -setSpaceQuota 1TB /user
> setSpaceQuota: / by zero
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4254) Cannot setSpaceQuota to 1TB
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-4254:
---------------------------------
Attachment: HADOOP-4254.patch
> Cannot setSpaceQuota to 1TB
> ---------------------------
>
> Key: HADOOP-4254
> URL: https://issues.apache.org/jira/browse/HADOOP-4254
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Raghu Angadi
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4254.patch, HADOOP-4254.patch
>
>
> When setting space quota to 1TB, it shows "/ by zero".
> {noformat}
> bash-3.2$ ./bin/hadoop dfsadmin -setSpaceQuota 1TB /user
> setSpaceQuota: / by zero
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4254) Cannot setSpaceQuota to 1TB
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634265#action_12634265 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-4254:
------------------------------------------------
"Prefix" here means prefix to the unit, i.e. B (bytes) in our case.
For references, see http://en.wikipedia.org/wiki/Binary_prefixes and http://physics.nist.gov/cuu/Units/binary.html
> Cannot setSpaceQuota to 1TB
> ---------------------------
>
> Key: HADOOP-4254
> URL: https://issues.apache.org/jira/browse/HADOOP-4254
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Raghu Angadi
> Priority: Blocker
> Fix For: 0.19.0
>
>
> When setting space quota to 1TB, it shows "/ by zero".
> {noformat}
> bash-3.2$ ./bin/hadoop dfsadmin -setSpaceQuota 1TB /user
> setSpaceQuota: / by zero
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4254) Cannot setSpaceQuota to 1TB
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635140#action_12635140 ]
Hudson commented on HADOOP-4254:
--------------------------------
Integrated in Hadoop-trunk #616 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/616/])
> Cannot setSpaceQuota to 1TB
> ---------------------------
>
> Key: HADOOP-4254
> URL: https://issues.apache.org/jira/browse/HADOOP-4254
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Raghu Angadi
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4254.patch, HADOOP-4254.patch
>
>
> When setting space quota to 1TB, it shows "/ by zero".
> {noformat}
> bash-3.2$ ./bin/hadoop dfsadmin -setSpaceQuota 1TB /user
> setSpaceQuota: / by zero
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4254) Cannot setSpaceQuota to 1TB
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634232#action_12634232 ]
Raghu Angadi commented on HADOOP-4254:
--------------------------------------
right. we could use {{StringUtils.TraditionalBinaryPrefix}} . Should it be 'suffix' rather?
It will change documentation for -setSpaceQuota a bit, but that should be fine I think.
> Cannot setSpaceQuota to 1TB
> ---------------------------
>
> Key: HADOOP-4254
> URL: https://issues.apache.org/jira/browse/HADOOP-4254
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Raghu Angadi
> Priority: Blocker
> Fix For: 0.19.0
>
>
> When setting space quota to 1TB, it shows "/ by zero".
> {noformat}
> bash-3.2$ ./bin/hadoop dfsadmin -setSpaceQuota 1TB /user
> setSpaceQuota: / by zero
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-4254) Cannot setSpaceQuota to 1TB
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi reassigned HADOOP-4254:
------------------------------------
Assignee: Raghu Angadi
> Cannot setSpaceQuota to 1TB
> ---------------------------
>
> Key: HADOOP-4254
> URL: https://issues.apache.org/jira/browse/HADOOP-4254
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Raghu Angadi
> Priority: Blocker
> Fix For: 0.19.0
>
>
> When setting space quota to 1TB, it shows "/ by zero".
> {noformat}
> bash-3.2$ ./bin/hadoop dfsadmin -setSpaceQuota 1TB /user
> setSpaceQuota: / by zero
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4254) Cannot setSpaceQuota to 1TB
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-4254:
---------------------------------
Resolution: Fixed
Release Note:
-setSpaceQuota command does not convert "TB" extenstion to
terabytes properly. Implementation now uses StringUtils for parsing this.
Status: Resolved (was: Patch Available)
I just committed this.
> Cannot setSpaceQuota to 1TB
> ---------------------------
>
> Key: HADOOP-4254
> URL: https://issues.apache.org/jira/browse/HADOOP-4254
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Raghu Angadi
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4254.patch, HADOOP-4254.patch
>
>
> When setting space quota to 1TB, it shows "/ by zero".
> {noformat}
> bash-3.2$ ./bin/hadoop dfsadmin -setSpaceQuota 1TB /user
> setSpaceQuota: / by zero
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4254) Cannot setSpaceQuota to 1TB
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-4254:
----------------------------------
Priority: Blocker (was: Major)
Affects Version/s: 0.19.0
Fix Version/s: 0.19.0
> Cannot setSpaceQuota to 1TB
> ---------------------------
>
> Key: HADOOP-4254
> URL: https://issues.apache.org/jira/browse/HADOOP-4254
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
>
> When setting space quota to 1TB, it shows "/ by zero".
> {noformat}
> bash-3.2$ ./bin/hadoop dfsadmin -setSpaceQuota 1TB /user
> setSpaceQuota: / by zero
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4254) Cannot setSpaceQuota to 1TB
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-4254:
------------------------------------
Release Note: (was: -setSpaceQuota command does not convert "TB" extenstion to
terabytes properly. Implementation now uses StringUtils for parsing this.
)
> Cannot setSpaceQuota to 1TB
> ---------------------------
>
> Key: HADOOP-4254
> URL: https://issues.apache.org/jira/browse/HADOOP-4254
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Raghu Angadi
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4254.patch, HADOOP-4254.patch
>
>
> When setting space quota to 1TB, it shows "/ by zero".
> {noformat}
> bash-3.2$ ./bin/hadoop dfsadmin -setSpaceQuota 1TB /user
> setSpaceQuota: / by zero
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HADOOP-4254) Cannot setSpaceQuota to
1TB
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633968#action_12633968 ]
szetszwo edited comment on HADOOP-4254 at 9/23/08 5:27 PM:
-------------------------------------------------------------------------
The problem is due to the constructor of SetQuotaCommand. There is a int overflow for setting multiplier = 1024 * 1024 * 1024 * 1024, where the type of multiplier is long. A simple fix is to change 1024 to 1024L. I suggest to use StringUtils.TraditionalBinaryPrefix for parsing the string.
was (Author: szetszwo):
The problem is due to the constructor of SetQuotaCommand. There is a int overflow for setting multiplier = 1024 * 1024 * 1024 * 1024, where the type of multiplier is long. A simple fix is to change 1024 to 1024L. I suggest we use StringUtils.TraditionalBinaryPrefix to parsing the value.
> Cannot setSpaceQuota to 1TB
> ---------------------------
>
> Key: HADOOP-4254
> URL: https://issues.apache.org/jira/browse/HADOOP-4254
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
>
> When setting space quota to 1TB, it shows "/ by zero".
> {noformat}
> bash-3.2$ ./bin/hadoop dfsadmin -setSpaceQuota 1TB /user
> setSpaceQuota: / by zero
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4254) Cannot setSpaceQuota to 1TB
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634793#action_12634793 ]
Hadoop QA commented on HADOOP-4254:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12390976/HADOOP-4254.patch
against trunk revision 699119.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3377/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3377/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3377/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3377/console
This message is automatically generated.
> Cannot setSpaceQuota to 1TB
> ---------------------------
>
> Key: HADOOP-4254
> URL: https://issues.apache.org/jira/browse/HADOOP-4254
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Raghu Angadi
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4254.patch, HADOOP-4254.patch
>
>
> When setting space quota to 1TB, it shows "/ by zero".
> {noformat}
> bash-3.2$ ./bin/hadoop dfsadmin -setSpaceQuota 1TB /user
> setSpaceQuota: / by zero
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4254) Cannot setSpaceQuota to 1TB
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-4254:
---------------------------------
Attachment: HADOOP-4254.patch
Thanks Nicholas. Could you review the attached patch?
> Cannot setSpaceQuota to 1TB
> ---------------------------
>
> Key: HADOOP-4254
> URL: https://issues.apache.org/jira/browse/HADOOP-4254
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Raghu Angadi
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: HADOOP-4254.patch
>
>
> When setting space quota to 1TB, it shows "/ by zero".
> {noformat}
> bash-3.2$ ./bin/hadoop dfsadmin -setSpaceQuota 1TB /user
> setSpaceQuota: / by zero
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.