You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2022/02/23 20:18:41 UTC
[Impala-ASF-CR] IMPALA-11150: Remove resource-requirements tests on functional parquet.alltypes
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18267
Change subject: IMPALA-11150: Remove resource-requirements tests on functional_parquet.alltypes
......................................................................
IMPALA-11150: Remove resource-requirements tests on functional_parquet.alltypes
These test became flaky after IMPALA-10961 as it led to smaller and
varying size for the table. This is a short term solution to make
builds green as fixing the tests properly may take some time.
Change-Id: I5bf0f963d3e053345aec27e834974eeead4190ac
---
M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test
1 file changed, 0 insertions(+), 263 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/18267/1
--
To view, visit http://gerrit.cloudera.org:8080/18267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bf0f963d3e053345aec27e834974eeead4190ac
Gerrit-Change-Number: 18267
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-11150: Remove resource-requirements tests on functional parquet.alltypes
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18267 )
Change subject: IMPALA-11150: Remove resource-requirements tests on functional_parquet.alltypes
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bf0f963d3e053345aec27e834974eeead4190ac
Gerrit-Change-Number: 18267
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Feb 2022 22:54:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11150: Remove resource-requirements tests on functional parquet.alltypes
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18267 )
Change subject: IMPALA-11150: Remove resource-requirements tests on functional_parquet.alltypes
......................................................................
IMPALA-11150: Remove resource-requirements tests on functional_parquet.alltypes
These test became flaky after IMPALA-10961 as it led to smaller and
varying size for the table. This is a short term solution to make
builds green as fixing the tests properly may take some time.
Change-Id: I5bf0f963d3e053345aec27e834974eeead4190ac
Reviewed-on: http://gerrit.cloudera.org:8080/18267
Reviewed-by: Fang-Yu Rao <fa...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Csaba Ringhofer <cs...@cloudera.com>
---
M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test
1 file changed, 0 insertions(+), 263 deletions(-)
Approvals:
Fang-Yu Rao: Looks good to me, but someone else must approve
Csaba Ringhofer: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5bf0f963d3e053345aec27e834974eeead4190ac
Gerrit-Change-Number: 18267
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11150: Remove resource-requirements tests on functional parquet.alltypes
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18267 )
Change subject: IMPALA-11150: Remove resource-requirements tests on functional_parquet.alltypes
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bf0f963d3e053345aec27e834974eeead4190ac
Gerrit-Change-Number: 18267
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Feb 2022 22:53:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11150: Remove resource-requirements tests on functional parquet.alltypes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18267 )
Change subject: IMPALA-11150: Remove resource-requirements tests on functional_parquet.alltypes
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10216/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bf0f963d3e053345aec27e834974eeead4190ac
Gerrit-Change-Number: 18267
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Feb 2022 20:41:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11150: Remove resource-requirements tests on functional parquet.alltypes
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18267 )
Change subject: IMPALA-11150: Remove resource-requirements tests on functional_parquet.alltypes
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bf0f963d3e053345aec27e834974eeead4190ac
Gerrit-Change-Number: 18267
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Feb 2022 20:57:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11150: Remove resource-requirements tests on functional parquet.alltypes
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18267 )
Change subject: IMPALA-11150: Remove resource-requirements tests on functional_parquet.alltypes
......................................................................
Patch Set 1:
Thanks very much for the help Csaba! I do not have any additional comment on this patch.
--
To view, visit http://gerrit.cloudera.org:8080/18267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bf0f963d3e053345aec27e834974eeead4190ac
Gerrit-Change-Number: 18267
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Feb 2022 20:56:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11150: Remove resource-requirements tests on functional parquet.alltypes
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18267 )
Change subject: IMPALA-11150: Remove resource-requirements tests on functional_parquet.alltypes
......................................................................
Patch Set 1:
Merging this without test run to unblock tests quickly
--
To view, visit http://gerrit.cloudera.org:8080/18267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bf0f963d3e053345aec27e834974eeead4190ac
Gerrit-Change-Number: 18267
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Feb 2022 22:54:45 +0000
Gerrit-HasComments: No